Increaseo

Thank you @webaware – we’ve tested this to be working perfectly. Appreciated! ??

Hey @webaware I’m following up above – is the status change something that should work within the plugin or is that for something to do?

We’d rather not create temp fix if this should be done by plugin – but can create a workaround on our end if won’t be fixed at plugin level.

Any clarity you could provide if you’ll consider fixing or not would be appreciated, thank you!

Hi @webaware the new filter is working otherwise as expected, but the order status is getting set as Processing, not On hold.

Code example:

function inc_woocommerce_eway_method_capture( $capture ) {
	$custom_product_id = get_page_by_title( 'x', OBJECT, 'product' );
	$cart_content_ids  = array_merge(
		wp_list_pluck( WC()->cart->get_cart_contents(), 'variation_id' ),
		wp_list_pluck( WC()->cart->get_cart_contents(), 'product_id' )
	);
	if ( in_array( $custom_product_id->ID, $cart_content_ids, true ) ) {
		$capture = false;
	}
	return $capture;
}
add_filter( 'woocommerce_eway_method_capture', 'inc_woocommerce_eway_method_capture', 10, 1 );

Should we be manually setting that or should that be automatic with https://github.com/webaware/eway-payment-gateway/blob/master/includes/integrations/class.WooCommerce.php#L588-L595 ?

Thanks!

• This reply was modified 2 years, 4 months ago by Increaseo.

Thank you for the speedy response and filter – really appreciated! ??

Same for us, here’s what we found out if someone wants to debug further:

FILE favorites/app/Entities/FavoriteList/FavoriteListingPresenter.php FUNCTION private function replaceCustomFields()

$meta = get_post_meta($this->favorite, $key, true);

doesn’t work. When we changed to ACF model:

$meta = get_field( "$key", $this->favorite);

we were able to get the first value when using shortcode [our_custom_field], if our ACF field was named car we’d use [car] or named field_cars [field_cars].

We ended up hardcoding the shortcodes like this:

private function replaceCustomFields() {
$field = get_field( "our_custom_field", $this->favorite);
$this->html = str_replace('[our_custom_field]', $field, $this->html);
}

The issue with original function is (at least):

– it doesn’t work with ACF
– when changing to use get_field( "$key", $this->favorite) it only gets the first one

Thanks @neookano – this fixed also Woocommerce category filtering issue!

Smuglet – best be you create your own thread as I’ve marked this one resolved and yours is a different issue ??

Found answer at https://wordpress.stackexchange.com/questions/233189/overriding-wp-login-credentials/233214

Would be nice if this was in the docs, would save the google session hours ??