ianbutty

Oh yes…! (I hope I have formatted this correctly for the forum!

Here in work()

foreach ( $links as $link ) {
					//Does this link need to be checked? Excluded links aren't checked, but their URLs are still
					//tested periodically to see if they're still on the exclusion list.
					if ( ! $this->is_excluded( $link->url ) ) {
						//Check the link.
						//FB::log($link->url, "Checking link {$link->link_id}");
						
						// ******** Code added by IMB 
						
						$mysiteurl ="//making-photos.co.uk/wp-content/uploads/";
                        $amazons3url = "//makingphotos.s3.eu-west-2.amazonaws.com/wp-content/uploads/";
                        $originallink = $link->url;
                        $link->url = str_replace($mysiteurl,$amazons3url,$originallink);

						// ******** End Code added by IMB 

						$link->check( true );
					} else {

and in ajax_recheck() ….

//In case the immediate check fails, this will ensure the link is checked during the next work() run.
$link->last_check_attempt = 0;
$link->isOptionLinkChanged = true;
$link->save();

//Check the link and save the results.

// ******** Code added by IMB

$mysiteurl =”//making-photos.co.uk/wp-content/uploads/”;
$amazons3url = “//makingphotos.s3.eu-west-2.amazonaws.com/wp-content/uploads/”;
$originallink = $link->url;
$link->url = str_replace($mysiteurl,$amazons3url,$originallink);

// ******** End Code added by IMB

$link->check( true );`

Hopefully, you will spot something that I have missed.

• This reply was modified 3 years, 2 months ago by ianbutty.

Hi Adam
Thanks for the info – I’ll see if I can get Eric’s work round to work.

Hi Eric
I tried the fix but I’m struggling to get it to work.
I couldn’t find “$link->chck( true )” in the code
but did find two instances of “$link->check( true )”

Adding the suggested fix before the one in function work() didn’t appear to make any difference.

The second instance is in function ajax_recheck() which did make a difference BUT now I get “403 forbidden” as the result of the check. Presumably, this is because broken link checker doesn’t know my S3 access key/credentials?

Thanks Eric – that’s a fair point.

Have you found that you have had to re-implement your fix often (ie does the frequency of updates to the plug-in cause issues)?

I have exactly the same issue on my site – is it worth implementing Eric’s solution or is the promised update imminent?

Are there any pros/cons to simply manually marking those reported links as “not broken” or as “dismissed”?

Thanks
Ian.

PS. Sorry to hijack someone else’s thread but it seemed sensible for future searches to keep the information all in one place rather than over two threads.

Thank you for your reply and the screencast (which you emailed me) which clearly shows what I need to do – unfortunately this only generates an error.

Please see this screencast showing what happens: https://youtu.be/8MSur90M_Pc

I hope you are able to help further,
All the best
Ian.

I am thinking of using this plug-in – but it sounds like this may be an issue for my site, I have a lot of media that I need to move to S3.

I’d be interested to find out how others have dealt with this problem and whether the problem has caused any long-term issues on their sites.

Also input from the developer would be useful.

One thought I had was to assign members to a custom (WP) role. But couldn’t see a way in EM pro to resrict tickets to a particular role. Only “everyone” “loged in users” and “guest users”

Also having the same problem – anyone got a fix for this yet?

Does exactly what I need – thank you. For reference here is how I am using it.

[private role="none"]This text is only visible in the editor![/private]

Thanks again for your help with this.
Ian.

That sounds like it should work. Any idea when the 3.0 release will be coming out?

What happens if you don’t put the ‘recipient=’ keyword? Does that mean the text will be displayed to noone? (Which is exactly what I want!). If the the ‘recipient=’ keyword is needed that’s not a problem, I will just create a dummy account.

You missunderstood what I meant by seeing it only in the editor – I meant the text and short codes would be visible in the editor… exactly as you type it in. Not looking for the shortcode to be rendered at that point… as you say that IS impossible!

Thanks

Actually I think I have found out how to get this two minor changes to the plugin….

In includes/lcp-parameters.php look for

if($this->utils->lcp_not_empty('monthnum')):
      $args['monthnum'] = $params['monthnum'];
    endif;

and add below it

if($this->utils->lcp_not_empty('day')):
      $args['day'] = $params['day'];
    endif;

Then in list_cat_posts.php search for

'monthnum' => '',

and then below it add:

'day' => '',

This means you can then use:
[catlist monthnum=12 day=25] to display all post on Christmas day.

Any chance these changes can be added to the plug-in code? So that I won’t have to re-add them everytime there is an update?

The primary purpose is to help me make my selections and then I can create a post about something that happened x years ago on a particular date.

So in terms of workflow ideally it is something I can access by just typing something into the address bar. In the same way that typing
https://www.ians-studio.co.uk/2013/04/ gives me a list all all the posts on the posts in April 2013.

Something like
https://www.ians-studio.co.uk/postbydate/04/19/ or
https://www.ians-studio.co.uk/postbydate.pho?month=4&date=19 or….

I guess the alternative would be a page where you can select a month and date click ok and then it displays all the posts matching the criteria. But that’s probably more complex to create and although it would be nice – not strictly necessary.

I can see how the code quoted can select the posts but I wouldn’t have the foggiest as to which file in wordpress I would have to edit and add it to. I am an EX-coder (I have coded in PHP in the past). I left the IT industry 12 years ago and haven’t done any serious coding since. I have never got into changing code in wordpress and while I’m happy to have a try I’m starting from just about zero knowledge of how the code in wordpress works and which files I’d need to modify.

I have the same problem. How do I get hold of the development version. I have an urgent mailing to 450 clients that should have gone out 8hrs ago!

Thanks
Ian.

I agree it is very strange. I was really surprised when deactivating CpD cured the problem and reactivating it caused the problem to come back. But it is definitely repeatable!

Thank you. That works.