Hyyan Abo Fakher
Forum Replies Created
-
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] Activate fatal errorYou need PHP5.3+ , update your php version
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] WooCommerce Polylang IntegrationI consider this topic as solved topic, just create a new one if you have any problem
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] WooCommerce Polylang IntegrationNot at all, the plugin will not delete any of your existing work
Forum: Reviews
In reply to: [Hyyan WooCommerce Polylang Integration] Please test the new versionI am glad that you do understand the current situation now , as you have said I have accepted all PRs that could be merged into the plugin code and added Some Fixes to keep the plugin up with latest version of its deps
For decarvalhoaa fixes, I can merge some of them manually,as they can not be sent as PR, I will contact decarvalhoaa and ask him if that is OK , or we can find another way.
I would recommend to raise all issues into the orginal plugin repo, but I will keep an eye on the currenrt issues in decarvalhoaathe branch too.
Working on that , thanks for reporting
Fixed in version 0.27
Please check this https://github.com/hyyan/woo-poly-integration/issues/5
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] Widget titles not translated?The plugin Woocommerce Currency Switcher is not supported yet
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] Delete PluginPlease , uninstall the plugin from wordpress plugins page and everything will work.
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] product urlCheck wordpress permalinks settings please
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] translate product permalink baseAll can be changed in wordpress permalinks settings
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] wordpress 4.5.3Fixed in 0.27
Forum: Plugins
In reply to: [Hyyan WooCommerce Polylang Integration] error in translationFixed in 0.27
Fixed in v0.27
Forum: Reviews
In reply to: [Hyyan WooCommerce Polylang Integration] Please test the new versionHello @jonathan
let me clarify the things a little bit in here , as this post is not totally correct .
I have contacted decarvalhoaa two weeeks ago:
Hello Antonio
This is Hyyan Abo Fakher the author of woopoly plugin.
I am contacting you so we can work together to improve the plugin.
As you know I was not able to maintain the project for a while because of my tough situation here in Germany as a Syrian refugee – Yes I am a refugee –
I took a look in What you have achieved so far and I like it. And I would like to Start merging your Patches in the plugin core and push a new update to the wordpress repo.
If you are interested, please contact me back so we could plan a workflow together.
Because I am working now, I would be able to maintain the plugin in the weekends only.
…..Since I was unsure you would continue working on your plugin, on request from some folks I have started preparing to publish my fork on www.remarpro.com. You may have seen that there is quite a lot of commits to prepare this. It will not be straight forward to pull back to your plugin only the bug fixing related commits. Anyway, we can work on that.
Thanks for contacting me back , As I can see you have already published your fork in wordpress repo, I am not really a fan of this idea, as your fork contains only bug fixes and does not contain major features, and that will be confusing for the plugin users as they won’t be sure what plugin to use , Anyway you are free to do that of course, and I will understand if you do not want to share your work back as PR to my Repo
there is no issue in making a PR to your repo. I was only mentioned that there is a bunch of code changes that for sure you will not want in your plugin. Changes related to prepare the plugin for www.remarpro.com. How do you want to deal with that? …..
As you can I am already working on finding a way to integrate decarvalhoaa work in this plugin, but the problem as it seems it that decarvalhoaa commits are not really clean to be merged directly as PR into the plugin repo.and I want to keep a clean code in the plugin repo. but this is something to do in the near future for sure .
For now I am working on releasing a new version which will fix some issues related to the newest versions of woocommerece and polylang.I hope I can release my work soon enough.