hunefalk
Forum Replies Created
-
Forum: Plugins
In reply to: [SEO Ultimate] Reporting failure – PHP NoticeI’m guessing this is the same PHP Notice as I’ve been seeing for a while in our logs:
[13-Sep-2016 07:49:30 UTC] PHP Notice: Undefined index: 00 in /mnt/hgfs/www/mywebsite.org/wp-includes/class-wp-locale.php on line 312
[13-Sep-2016 07:49:30 UTC] PHP Stack trace:
[13-Sep-2016 07:49:30 UTC] PHP 1. shutdown_action_hook() /mnt/hgfs/www/mywebsite.org/wp-includes/load.php:0
[13-Sep-2016 07:49:30 UTC] PHP 2. do_action() /mnt/hgfs/www/mywebsite.org/wp-includes/load.php:671
[13-Sep-2016 07:49:30 UTC] PHP 3. call_user_func_array:{/mnt/hgfs/www/mywebsite.org/wp-includes/plugin.php:524}() /mnt/hgfs/www/mywebsite.org/wp-includes/plugin.php:524
[13-Sep-2016 07:49:30 UTC] PHP 4. wp_ob_end_flush_all() /mnt/hgfs/www/mywebsite.org/wp-includes/plugin.php:524
[13-Sep-2016 07:49:30 UTC] PHP 5. ob_end_flush() /mnt/hgfs/www/mywebsite.org/wp-includes/functions.php:3598
[13-Sep-2016 07:49:30 UTC] PHP 6. SU_Titles->change_title_tag() /mnt/hgfs/www/mywebsite.org/wp-includes/functions.php:3598
[13-Sep-2016 07:49:30 UTC] PHP 7. SU_Titles->get_title() /mnt/hgfs/www/mywebsite.org/wp-content/plugins/seo-ultimate/modules/titles/titles.php:146
[13-Sep-2016 07:49:30 UTC] PHP 8. WP_Locale->get_month() /mnt/hgfs/www/mywebsite.org/wp-content/plugins/seo-ultimate/modules/titles/titles.php:198It might be related to this:
[13-Sep-2016 07:49:30 UTC] PHP Notice: Undefined index: 00 in /mnt/hgfs/www/mywebsite.org/wp-includes/class-wp-locale.php on line 312
[13-Sep-2016 07:49:30 UTC] PHP Stack trace:
[13-Sep-2016 07:49:30 UTC] PHP 1. shutdown_action_hook() /mnt/hgfs/www/mywebsite.org/wp-includes/load.php:0
[13-Sep-2016 07:49:30 UTC] PHP 2. do_action() /mnt/hgfs/www/mywebsite.org/wp-includes/load.php:671
[13-Sep-2016 07:49:30 UTC] PHP 3. call_user_func_array:{/mnt/hgfs/www/mywebsite.org/wp-includes/plugin.php:524}() /mnt/hgfs/www/mywebsite.org/wp-includes/plugin.php:524
[13-Sep-2016 07:49:30 UTC] PHP 4. wp_ob_end_flush_all() /mnt/hgfs/www/mywebsite.org/wp-includes/plugin.php:524
[13-Sep-2016 07:49:30 UTC] PHP 5. ob_end_flush() /mnt/hgfs/www/mywebsite.org/wp-includes/functions.php:3598
[13-Sep-2016 07:49:30 UTC] PHP 6. SU_Titles->change_title_tag() /mnt/hgfs/www/mywebsite.org/wp-includes/functions.php:3598@m-rub-shuvo I’ve also been seeing the add_utility_page notice. Since you mentioned it, is it being resolved soon?
Forum: Plugins
In reply to: [a3 Lazy Load] Thumbnails do not loadLooks like the 1.5.1 update fixed my issues. Hopefully the same for Texiwill.
Thanks for a great plugin ??
Forum: Plugins
In reply to: [a3 Lazy Load] Thumbnails do not loadAfter some more testing it might not be exactly the same issue as Texiwill has. If I turn off lazy loading for thumbnails the lazy loading works on the post thumbnails on category pages (which it shouldn’t after turning it off), and data-src only shows once in the img attribute.
EDIT: Without looking too deep in the plugin code, I’m guessing it’s run twice since in class-a3-lazy-load.php you have the wp_get_attachment_image_attributes filter with attributes (row 261), and then also run filter_images() with preg_replace on img tags.
Forum: Plugins
In reply to: [a3 Lazy Load] Thumbnails do not loadHi, this seems like the same issue we’re having after updating to a3ll 1.5.0 and WP 4.4.
On category pages we’re loading 10 posts per page, but only the thumbnail for the first one is showing up. From what I can see in the shortcode the problem is that data-src (and also data-lazy-type) is showing up twice in the image tags, except for on the first one. The second data-src points to the placeholder image while the first one is the real post image. The javascript probably catches the second data-src, thereby replacing the placeholder with the placeholder.
I only updated on my local environment so far, so can’t show you on our live site since it still has the old version. To give you an example:
<img width="150" height="150" src="//local/wp-content/plugins/a3-lazy-load/assets/images/placeholder.gif" data-lazy-type="image" data-src="//local/wp-content/plugins/a3-lazy-load/assets/images/placeholder.gif" class="lazy lazy-hidden lazy-hidden attachment-thumbnail size-thumbnail wp-post-image" alt="Bingo Legends: Striving to be the Best" title="Bingo Legends: Striving to be the Best" data-src="https://local/path/to/image.gif" data-lazy-type="image" /> <noscript><img width="150" height="150" src="//local/wp-content/plugins/a3-lazy-load/assets/images/placeholder.gif" class="lazy-hidden attachment-thumbnail size-thumbnail wp-post-image" alt="post title" title="post title" data-src="https://local/path/to/image.gif" data-lazy-type="image" /></noscript>
As you can see, the img tag in noscript is also getting the placeholder image. I’m guessing it’s running the preg_replace on thumbnails twice for some reason, but can’t see where that would happen. The javsscript part seems to be working, besides catching the wrong data-src. I also noticed the noscript version has the placeholder and then the original image in data-src, looking even more like it runs twice.
We include the thumbnails like this in the template:
if (has_post_thumbnail()) { the_post_thumbnail( 'thumbnail', array( 'alt' => trim( strip_tags( get_the_title() ) ), 'title' => trim( strip_tags( get_the_title() ) ) ) ); } else { echo "<img src='" . get_stylesheet_directory_uri() . "/images/layout/default-no-image.png' />"; }
I tried turning off noscript, but data-src was still showing up twice in the img tags.
Lazy loading works as expected on other page types, including for example an image gallery – it’s only when looping category posts we’re having an issue with the post thumbnails.