hugodebe

hi pierre, the same problem for me. do you have any progress on this topic?

thanks
hugo

Thanks for your reply. To help me understand, using the post_playlist filter will have the same result than recreating the shortcode?

remove_shortcode('playlist');
add_shortcode('playlist', 'my_custom_playlist_shortcode');

In both methods I have to copy all the code to customize the output, right? Is the filter a better approach than recreating the shortcode and why?

I can request your help through the premium support website, but as you told before, this had already been resolved for the premium themes.

Now I’m adding the js you sent to custom.js from my child theme directory. JS minification continues disabled.

When adding the js code to a text widget into the footer area, it didn’t seems to be loading. I was able to see it in the page source but it didn’t appeared when looking through the firefox debugger. Then I had a try using the Header and Footer Scripts plugin and I was able to see the script from the debugger. If you accessed the website earlier today, your code was in the header. Now you should find it easily into custom.js

Hi Ben, did you managed to update your code with the no-lightbox class, to disable the lightbox? Please, let me know if it will come in an update of the theme or the toolkit plugin.

Otherwise, could you test again to the website? The download buttons aren’t working at all, even with the js minify disabled.

The site owner really would like this new feature to work now. He is a 2016 kadence customer as we implemented virtue premium on another project. I hope it can help you spend a bit more of time on this support request… ??

Thanks in advance.
Hugo

Hi Ben,

The download buttons is really not working for me, independently of the browser I use, with the cache cleaned.

When I click a download button, it opens the lightbox.

Thanks for your reply Ben.

I had already try to disable js minifying and/or load the script in the header, without success. You can have a look to this configuration accessing the website again.

I can’t see any error anymore in the Console. Please, can you see what am I doing wrong?

I removed the normal lightbox link on the image and rebuild my layout/css to display the buttons under the images on mobiles (under 767px). Images aren’t seen 3 times anymore by the lightbox, but I still have them twice as my download button link is seen as a lightbox link. I can’t find why the script sent by Ben isn’t working. Please, help!

Here is the link: combibresil.com/puma-gt-1600-bresil-1972-ref-pu04

• This reply was modified 8 years ago by hugodebe.

Hi Ben, I sent the link to the Kadence Facebook Page. Do you have access to it?

The reason I kept the normal lightbox link is for mobile compatibility. For small devices I hide both buttons and use the normal link only. I will have to think about another approach…

Hi Ben, Hannah, thanks a lot for the quick reply. That’s what I was looking for!

I added the class and the script Ben provided but it’s not working yet for me. I also noticed that the number of pics in the gallery lightbox has been triplicated. What am I doing wrong?

$output .= '<div class="'.esc_attr($itemsize).' g_item"><div class="grid_item kad_gallery_fade_in gallery_item"><a href="'.esc_url($attachment_url).'" '.$lightbox_data.' class="lightboxhover">';
    $output .= '<img src="'.esc_url($image[0]).'" width="'.esc_attr($image[1]).'" height="'.esc_attr($image[2]).'" alt="'.esc_attr($alt).'" '.$img_srcset_output.' class="light-dropshaddow"/>';
     $output .= '</a></div>';
//Add the buttons for lightbox and download
    $output .= '<div class="image_links double"><a href="'.esc_url($attachment_url).'" '.$lightbox_data.' itemprop="image" class="zoom-image" title="Zoom"><i class="icon-zoom-in"></i></a>';
	$output .= '<a href="'.esc_url($attachment_url).'" data-download="picture.jpg" class="no-lightbox download-image" title="Download"><i class="icon-download-alt"></i></a>';
	$output .= '</div></div>';

/wp-content/plugins/virtue-toolkit-custom/gallery.php

I sent you a frontend link again, via fb messenger.

Thanks
Hugo

Hi @jeherve, OK for me. Google+ is back, thanks Jetpack!

Hi Hannah, thanks for your reply. I added the script in footer but it doesn’t look to be running when i look in debugger. I continue to have data-rel=”lightbox” added to the link:

<a href="https://example.com/wp-content/uploads/2016/11/image.jpg" data-download="picture.jpg" class="download-image" title="Download" data-rel="lightbox"><i class="icon-download-alt"></i></a>

Could you have a quick look and try to tell me what I am missing please? I sent you a page link in a message on the Facebook Page.

Hi francesdath, thanks for sharing.

That’s exactly the setup I have.

I would love to be able to minify html. It used to work in a recent past…

It has been more than a month now without this great feature… Any update from Google? Thanks in advance

Hi Ben, If I disable the theme gallery, the lightbox is disabled as well.

As I want to keep the theme lightbox, I made a custom version of the Toolkit Plugin where I replaced “400” by “230” (gallery.php line 152). I’m sure you don’t recommend to do so, but I now have what I wanted.

<img class="light-dropshaddow" 
     title="..." 
     alt="..."
     height="230" width="230"
     sizes="(max-width: 230px) 100vw, 230px" >
     src="https://example.com/wp-content/uploads/2016/10/image-230x230.jpg"
     srcset="
             https://example.com/wp-content/uploads/2016/10/image-230x230.jpg 230w, 
             https://example.com/wp-content/uploads/2016/10/image-60x60.jpg 60w, 
             https://example.com/wp-content/uploads/2016/10/[email protected] 460w" >

Both the 400×400 and 400×400@2x image sizes are not anymore generated when uploading. The 230×230@2x size images are automatically created for all my old images. It sounds perfect!

I will have a deeper look to bulk delete the old 400×400 thumbnails, to save space.

Many thanks Kadence for the support.

I’m working around something like this to override the sizes attribute:

function my_attachment_image_attributes( $attr, $attachment, $size ) {
    if ( $size === 'thumbnail' ) {
        $attr['sizes'] = '(max-width: 230px) 100vw, 230px';
    }
    return $attr;
}
add_filter( 'wp_get_attachment_image_attributes', 'my_attachment_image_attributes', 10, 3 );

Without success for now…