Hlsg

Thank you for that!

But it’s not about “not bothering” to read that warnign. I was very aware of what that button does and have used the bulk resize functionality in the past. Yet I still managed to hit it instead of the “save changes” one. Granted, I was kind of exhausted.
Mistakes do happen, which is why it’s best practice to always require confirmation before going into such an operation.

Cheers!

• This reply was modified 4 years, 3 months ago by Hlsg.

Am I wrong in my assertion?

Thank you for the clarification!

To be honest though, I would prioritize adding a confirmation dialog before starting the bulk resizing before anything else. That warning message is all good and nice, but such a potentially destructive and time consuming operation should be behind a confirmation dialog, IMHO.

Cheers!

v2.3.1 fixes this.

This is not specific to one website. It occurs on fresh WP installs.

https://plugintests.com/plugins/regenerate-thumbnails-advanced/latest

Unfortunately, i don;t seem to be getting email notifications on this, so I apologise again for the delay in my reply.

The error is observed in WP’s log file, and appears whether i install your plugin clasically or through WP-CLI.

Hi and sorry for the dalayed response!

I’m on PHP 7.4.7 but that online report implies that this happens on 7.2.16 aswell.

Excellent!

As much as I love your plugin, I must say that you documentation is a bit lacking. Better docs would go a long way towards reducing your workload answering such issues.

All that beeing said, thank you very much fot the info!

Sorry for not specifying: not using the block editor and don’t intend to anytime soom. And yeah, I struggle aswell to find any difference between content images and featured images upload.

I was hoping you woudl have a better idea.

Anyway, if you don’t, you can close this.

Thanks!

Please disregard m previous comment. It’s all good.

Thank you for the resource. I’ve managed to get this working, but not really. The functionality is there, but the plugin adds a comment which invalidates the nonce:

wp-login.php?action=logout&_wpnonce=da9312sdas<!-- Block generated by LiteSpeed Cache 2.9.9.2 on 2019-12-16 02:23:03 -->

I’ve also become aware that this particular issue with wp_logout_url can also be solvedes by simply adding if ( class_exists('LiteSpeed_Cache_API') ) LiteSpeed_Cache_API::nonce_action('log-out'); before the call, but I would prefer to do it like in the resource you provided since I have other blocks I want to use as ESIs andit’s better if I wrap my head well around your API.

Excellent! Thsi filter is exactly what was needed. I think you should mention in in the plugins description, as, presumalby, a good chunk of your user base will be familiar with filters.

All that beeing said, are you aware of any method of differentiating between an image uploaded within the post content and one through “set featured image”? $_REQUEST and $_SERVER[‘HTTP_REFERER’] are identical and therefore don’t help.

This is not solved, so please don’t mark it as such. I have figured out what code in my theme is conflicting with your plugin and it doesn;t seem to me that it should. It’s just adding some custom separators to the admin menu.

add_action( 'admin_init', 'custom_add_admin_menu_separator' );
function custom_add_admin_menu_separator( $position ) {

    global $menu;
    $menu[ $position ] = array(
        0   =>  '',
        1   =>  'read',
        2   =>  'separator' . $position,
        3   =>  '',
        4   =>  'wp-menu-separator'
    );

}

add_action( 'admin_menu', 'custom_set_admin_menu_separator' );
function custom_set_admin_menu_separator() {
    do_action( 'admin_init', "25.1" );
    do_action( 'admin_init', "35.1" );
}

Any ideas?

The environment is ubuntu-16.04 with PHP 7.2.11.

I’ve disabled all other plugins and the error persists.

I’ve also done a search on all teh files in the project for convert_stats and only the instances in png-to-jpg.php came up:

   37: 			function convert_stats( $content ){
   41: 			ob_start( 'convert_stats' );

The “…” part is redacted from /var/www/dev/dev6 ideed. I forgor to redact the second instance, but they were identical.

Fatal error: Cannot redeclare convert_stats() (previously declared in /var/www/dev/dev6/wp-content/plugins/png-to-jpg/png-to-jpg.php:37) in /var/www/dev/dev6/wp-content/plugins/png-to-jpg/png-to-jpg.php on line 37

Thank you!

• This reply was modified 6 years, 4 months ago by Hlsg.

Yeap. This needs server side validation all around.