Paul

I just tried the new beta version on one of my dev sites and I can confirm the Doing it Wrong warnings have been resolved ??

I deactivated and reactivated the beta plugin and there is a Doing it Wrong warning in your activation action handlers somewhere, but the plugin looks OK for general usage now.

I’m happy to help with additional testing if needs be.

I’ve gone back to a fresh dev site and double-checked. Here is what I’ve got:

• WordPress 6.7
• mu-plugins : none
• plugins:
  • Autoptimize 3.1.12
  • Query Monitor 3.16.4
• theme:
  • twentytwentyfive
• Site language: English (UK) << Important that you don’t use the default English (US)

When I view the admin dashboard, Query Monitor reports Autpotimize autoptimizeProTab.php line 24 is trying to access translation functions too early in the page load.

I’ve seen this a lot on my hosting network, and it’s mostly caused by plugins calling __() in class constructors, before the “init” action has triggered.

Does that help?

• This reply was modified 1 week ago by Paul.

Thanks for the update. I’ve downloaded version 1.36.2 and it now passes the tests in our PHP Malware scanner.

Appreciated ??

Thanks for updating the code and confirming. Appreciated. Have a great day.

We’re seeing the same thing with SR7 and Autoptimize here. I’m going to investigate and try to find a solution/workaround. I’ll update here if I find a neat way to solve it.

That cart icon in the primary nav definitely needs to take the user to the cart page when clicked. With the current configuration, the user is left “hanging”… they have to take additional action to get through to the site’s primary action (complete a purchase).

As there are use cases for both behaviours, please add an checkbox option so we can make the cart icon clickable again (as it should be).

@cariboulette Check that you have pasted the code correctly. Here is the code snippet with a bit more context (between START and END)

/**
 * Translators: the following error messages are shown to the end user
 */
$error_general = __('Transaction was unsuccessful. Please check the minimum amount or use another valid card.', 'sumup-payment-gateway-for-woocommerce');
$error_invalid_form = __('Fill in all required details.', 'sumup-payment-gateway-for-woocommerce');

// START fix log warnings --------------------------------
if (!array_key_exists('enable_pix', $this->settings)) {
    $this->settings['enable_pix'] = false;
}

if (!array_key_exists('open_payment_modal', $this->settings)) {
    $this->settings['open_payment_modal'] = false;
}
// END fix log warnings ----------------------------------

wp_localize_script('wc-sumup-blocks-integration', 'sumup_gateway_params', [
    'showInstallments' => "$show_installments",
    'sumup_handler_url' => add_query_arg(
        [
            'wc-api' => 'sumup_api_handler',
            'action' => 'create_checkout'
        ],
        home_url() . '/'
    ),
    'showZipCode' => "$show_zipcode",
    'maxInstallments' => $number_of_installments,
    'locale' => "$card_locale",
    'country' => '',
    'status' => '',
    'errors' => [
        'general_error' => "$error_general",
        'invalid_form' => "$error_invalid_form",
        'payment_error' => ''
    ],
    'enablePix' => $this->settings['enable_pix'],
    'openPaymentInModal' => $this->settings['open_payment_modal'],
    'redirectUrl' => ''
]);

I hope this helps

• This reply was modified 5 months, 3 weeks ago by Paul.
• This reply was modified 5 months, 3 weeks ago by Paul.

If you edit includes/class-wc-sumup-block-gateway.php and add the following snippet before the call to wp_localize_script(), it will get rid of the warnings safely:

if (!array_key_exists('enable_pix', $this->settings)) {
    $this->settings['enable_pix'] = false;
}

if (!array_key_exists('open_payment_modal', $this->settings)) {
    $this->settings['open_payment_modal'] = false;
}

I’ve run this patch on three sites now and the logs are clean again. It will do for now, until the author releases an update.

Hi

We experienced the same “missing customer information” problem with version 2.2.0. Reverting to version 2.1.0 seems to have restored normal operation. After a week of using 2.1.0 again, all PayPal orders have customer fields populated properly. I assume the fix will be rolled out in the next release?

OK thanks. I can confirm the following:

• I installed Yoast Test Helper and clicked “Reset Indexables tables & migrations”
• I went into Yoast > Tools and clicked “Start SEO data optimisation”
• Running “wp yoast cleanup” works again (i.e. it doesn’t stall/block any more).

Thank you for the solution

Looks like there’s a new build just been shipped, 3.7.9. I’ve tried it on two sites and it looks much better.

Phew

I found that rolling back to version 3.7.7 and then restarting php8.0-fpm fixed the issue.

I concur. I’ve applied the update on two sites, one with astra-addon and one without, and both sites went into a tailspin. The sites still worked, but they were slow and the access log filled with repeated POSTs to action=wp_astra_theme_db_migration&nonce…

@van-ons Version 2.0.2 looks to have fixed the problem. The version of FA being used is now the correct version from the theme and my social icons have come back – thanks.

Great – Just downloaded 3.0.1 and it looks OK on my test site. Cheers for the quick response! ??