Maik Penz

There is no common concept for ‘security’ update or even ‘changelogs’ in wp plugin development.

Basically it is up to the developer of a plugin to provide information on changes. Some add security notices, some tend to simply hide serious issues.

Therefore I would deem it impossible to distinguish between update types.

Seen to many ‘someone-can-read-my-database’-level issues brushed of as minor-release or patch level with nothing but a ‘code cleanup’ label.

Should have thought of that option.. Sounds good to me!

That is exactly where the problem lies: if the collate changes after the initial table create the plugin does use the wrong collate to access its table – causing a mysqlnd warning in the best case.

WordPress itself does update all its tables when enforcing utf8mb4.

Did that for one client but it is quiet a hazzle to do on multiple servers and installations.

How about a test on plugin-update that does this automatically to avoid log-spam for other users that upgraded from older WordPress versions?

Otherwise okay with me.

Seconding this one and serving non-optimised images to hundreds of thousands of users per day.

That was fast! Thanks!

Issue remains with latest version.

`
Notice: Undefined index: blocked_total in plugins/anti-spam/anti-spam-info.php on line 10
`

Great!

Thank you!

Hi Nick,

thank you!

Was not resolved on last update. Please fix this to no longer break PHP 5.5 installs without the deprecated mysql extension.

Found your github account (and spammed it). Glad you mentioned the beta.

I will have a look at it tomorrow and resolve this issue accordingly.

well, not sure the change above does fix the issue, it only made a message disappear for local testing and cloudflare cdn scripts.

Just wanted to put some attention to external scripts being registered with wp_enqueue_script by protocol relative url.

Great! Fast too. Almost nothing left for me!

Patch for admin class:

--- a/wp-content/plugins/simple-ads-manager/admin.class.php
+++ b/wp-content/plugins/simple-ads-manager/admin.class.php
@@ -28,7 +28,7 @@ if ( !class_exists( 'SimpleAdsManagerAdmin' && class_exists('SimpleAdsManager')

       register_activation_hook(SAM_MAIN_FILE, array(&$this, 'onActivate'));
       register_deactivation_hook(SAM_MAIN_FILE, array(&$this, 'onDeactivate'));
-      register_uninstall_hook(SAM_MAIN_FILE, array(&$this, 'onUninstall'));
+      register_uninstall_hook(SAM_MAIN_FILE, array(__CLASS__, 'onUninstall'));

       $options = parent::getSettings(false);
       if(!empty($options['access'])) $access = $options['access'];
@@ -99,7 +99,7 @@ if ( !class_exists( 'SimpleAdsManagerAdmin' && class_exists('SimpleAdsManager')
       }
     }

-    public function onUninstall() {
+    public static function onUninstall() {
       global $wpdb;
       $zTable = $wpdb->prefix . "sam_zones";
       $pTable = $wpdb->prefix . "sam_places";
@@ -223,7 +223,7 @@ if ( !class_exists( 'SimpleAdsManagerAdmin' && class_exists('SimpleAdsManager')
       if($vc == 2) {
         $subver = explode('-', $ver[1]);
         $version['minor'] = $subver[0];
-        $version['spec'] = $subver[1];
+        $version['spec'] = isset($subver[1]) ? $subver[1] : false;
         $version['str'] = $version['major'].'.'.$version['minor'].((!empty($version['spec'])) ? ' ('.$version['spec'].')' : '');
       }
       else {

May you drop windows line-feeds (\r\n) in favour of the more common unix line-feeds (\n), please? Getting mixed line endings with your plugin which did not seem to occur until the most recent update.

And your really should use the debug mode to test frontend and backend once before any release.
There may be some easy to catch issues like the errorlog flag or shortcode_atts misuse (integer cast instead of array_key_exist/ isset result referenced later on).