gheaven
Forum Replies Created
-
Forum: Plugins
In reply to: [Extensions for Leaflet Map] Hover Broken from WordPress 6.0Undo that last comment, It does work.
Forum: Plugins
In reply to: [Extensions for Leaflet Map] Hover Broken from WordPress 6.0But no, the problem still persists. I will keep an eye on the issue I raised in the wordpress world.
If this becomes a huge problem for me I will refactor that script out to a js file and submit a pull request to you. Other fish are on my plate at the moment.
Forum: Plugins
In reply to: [Extensions for Leaflet Map] Hover Broken from WordPress 6.0I develop on a windows 10 box and deploy to hosted linux so this is very useful.
I vaguely recall the advice to enclose javascript in non properly formed block comments in PHP (or was it ASP) somewhere years ago (like almost last century). Thanks for taking the time on this.
Forum: Plugins
In reply to: [Extensions for Leaflet Map] Hover Broken from WordPress 6.0Forum: Plugins
In reply to: [Extensions for Leaflet Map] Hover Broken from WordPress 6.0I have managed to do a minimal test that reproduces the problem. It only is a problem for an if statement nested in a for loop it seems.
I made a minimal shortcode and noted in the comments.
add_shortcode( 'test_ampersand', 'test_ampersand' ); function ta_init(){ function test_ampersand() { $text = '<script>'; ob_start(); ?>/*<script>*/ if (1==1) { if ((1 != 2 && 2==2 ) || 3==3) { null} } // Works for (var i=0; i < 2; i++) { if (1==1) { if ((1 != 2 && 2==2 ) || 3==3) { null} } } // Does not work if (1==1) { if ((1 != 2 && 2==2 ) || 3==3) { null} } // does not work now... <?php $javascript = ob_get_clean(); $text = $text . $javascript . '</script>'; return "\n".$text."\n Some Text"; } } add_action('init', 'ta_init');
I will raise a gutenberg bug now.
Forum: Plugins
In reply to: [Extensions for Leaflet Map] Hover Broken from WordPress 6.0Agree with the && being common.
This is running in a clean install of WordPress 6.0.2 on Local and with no other plugins. Only the instance in that if statement with nested conditions is impacted. All the other && instances render properly. I even commented out the Jshrink and the problem persists.
I will try and write my first ever minimal shortcode and see if I can reproduce it. I don’t think it is your problem.
I will leave it open for now as you may need to re-factor as a work around
Forum: Plugins
In reply to: [WP To Do] BrokenDownloading and adding jqueryui into the scripts directory got rid of the console errors, and added a few more. Application now tries to deactivate from the admin “add task” window. Looks to me like it is a bad build. Please review the package and test on a clean WP instance. Version 1.2.2
- This reply was modified 4 years, 1 month ago by gheaven.