getupworks

@anevins

We already ignore the star ratings, all we’re looking for is feedback for Gutenberg.

that’s exactly the problem. if you didn’t, you could start to listen to your community. what we want can be seen clearly in the star reviews.

that confused me as well

you can register a custom template for your amp pages by adding this to your themes functions.php

add_filter( 'amp_post_template_file', 'rdbhnd_amp_set_custom_template', 10, 3 );
function rdbhnd_amp_set_custom_template( $file, $type, $post ) {
 if ( 'single' === $type ) { $file = dirname( __FILE__ ) . '/amp/single.php'; }
 return $file;
}

in the next step, create a folder called “amp” inside your theme folder and copy single.php and meta-author.php from the plugins templates folder into your themes amp folder.
you can now customize the author image in the meta-author.php
works perfect here:
https://theroadbehind.de/radreisen/suedfrankreich-katalonien-pyrenaeen/amp/
(author image is at the bottom of the page)

• This reply was modified 6 years, 9 months ago by getupworks.

nice, thanks!

after some more testing this seems to work better, since it also gets the scroll animation:

#fancybox-title { position: absolute; bottom: -10px; }

This means that when the image has to be scaled down to fit the window, and there is not much room left below the image for that title then the script disables the center-on-scroll behavior so that visitors can scroll down to read the title.

makes sense. when i reduce the #fancybox-content height by a few pixels everything keeps centered. what confuses me is that it worked like this until the latest update.
i guess i assumed the script calculates the height of the viewport and the height of the title, and then scales the image accordingly. which would still be a problem with long texts.

This is actually a very nice solution. If you don’t mind, I’d like to add this as a new title position option in a future release ??

sure, glad i could help.
thanks for providing this plugin!

• This reply was modified 6 years, 10 months ago by getupworks.

@karmatosed i really appreciate you taking the time to reply to – from what i can tell – every comment on the plugin… anywhere. i’m sure by now you’ve heard all the cons and there’s really not much i could add there. what kills it for me are things like inline styles / accessibility, backwards compatibility, cooperation with existing plugins (like acf, which i use i.e. to create client specific layout builders), video embeds, backend clarity for clients.
i am aware of the classic editor plugin, but it’s the wrong approach imo: the system should be as simple as possible, with the option to extend it as needed with plugins, not the other way round.
i think the plugin you work on is very promising, but nothing that is needed by the majority of the wp users and therefor it shouldn’t be part of the core. why not make it “semi default” like that hello-dolly nonsense: ship it with the package, but still make it optional.

• This reply was modified 7 years, 3 months ago by getupworks.

hey @smashballoon,
thx for your detailed reply! i get your point and think something like this might be a good solution:
show the main menu entry on plugin activation as it is now, but have the actual options page within the settings menu, so the main menu item just links there.
then give the option to turn the main menu item off, very similar to what yoast seo does with their admin menu bar item.
sub-menu items within the settings menu are often done with tabs.
thx + best
nico

update: sorry, i checked again: p.rfbp-post-link-wrap is actually still there, it is p.rfbp-link-wrap and its content that disappears

• This reply was modified 8 years, 1 month ago by getupworks.