genericname

The desktop/mobile version of the sites were doing it that way so I wanted to keep it consistent. If that’s the case I’ll change it to use the <i> tag.

Thank you.

Thank you that helped with the social share icons! The only remaining issue is the missing fontAwesome icons. In one of the screenshots I posted above there should be a hamburger icon on the top left of the header bar but it is missing for some reason. It seems like anything that uses the ::before selector is missing its content on the page.

This is what I am using:

#amp-page-header .hamburger:before {
	color: black;
	content: "\f0c9";
	cursor: pointer;
	float: left;
	font: normal normal 25px/25px FontAwesome;
	height: 25px;
	overflow: hidden;
	padding: 8px;
	text-align: center;
	text-indent: 0;
	width: 25px;
}

Thank you. I just submitted the form with the information.

Hi @westonruter,

Just an update on some of the issues we had:

– Title was out of place because wp_head was not wrapped in a head tag in header.php

– We have a very large theme and the Reader theme we previously made was a child of it. We noticed a lot of random things were bleeding through so what we ended up doing was making it a separate theme and handpicking modules from the main theme.

• This reply was modified 3 years, 7 months ago by genericname.

It seems to be an issue with wp_head causing the head to close early. The title and many of the other tags in the head were pushed down to the beginning of the body because of it. It may have something to do with my Reader theme.

I’ll be looking more into it tomorrow or early next week. Will post results when I find out more.

Hi Weston,

The head closing prematurely seems to be the main culprit. We’ve found something internally that we’ll be looking at and testing out. Will close the ticket for the time being and reopen if necessary.

Thank you for the help.

The testing environment is unfortunately password protected. I will use the classes for now while looking more into this issue.

Thank you!

Hi Weston,

I am using the same cdn as the example you posted above. This is what I see in the page source:

<link crossorigin="anonymous" rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css?ver=4.7.0" type="text/css" media="all">

Hmm I just noticed that the icon will show up if I use the Font Awesome classes fa fa-bars instead of the unicode. Are there any reasons why it wouldn’t work with just the unicode?

• This reply was modified 3 years, 10 months ago by genericname.

Ah that was it! I was missing wp_footer().

Thank you.

Thank you!

Hi Renee,

I created a child theme of the main theme and included it as a Reader by adding AMP: true to style.css and then selecting it in admin.

Thank you!

Hi @westonruter

After some discussion we decided to move forward with a Reader theme. Would it be possible to create a custom Reader using a child theme of the main theme?

From what I understand, I’d have to create a plugin and then register the child theme using the amp_reader_themes filter? If it is a child theme would I then have to deregister all the extra style/scripts from the parent? I recall reading that there is a certain limit on how much css we can have.

• This reply was modified 4 years, 2 months ago by genericname.

Understood. It was mainly an issue on my end.

The reader was getting a 404 in console for /wp-json/amp/v1/reader-themes?_locale=user. So I checked the logs and discovered an error with register_rest_route in one of our REST routes.

The templates started loading afterwards by following:
https://amp-wp.org/documentation/playbooks/classic-templates/
https://gist.github.com/westonruter/d9cbdf39b040794c951520f8dc03f039

Thank you Weston. I was able to track down the problem.