Fabian Todt

I understand, thank you for the feedback! I looked into it and overlay UI is kind of complex and something I don’t want to implement in the custom block myself.

I will have a look into better supporting the cover block inside the slider. As a quick workaround, you can put a cover block inside a slide and apply the following CSS in your (child) theme/custom CSS in site editor:

.wp-block-good-slider .wp-block-good-slider__slide > .wp-block-cover {
    width: 100%;
    align-self: stretch;
}

This will make a cover block stretch the full width/height of your slide. I have not tested this extensively. But in a quick test it worked well enough.

I’ve also opened a GitHub issue here and here to track this. But I can’t promise any timeline atm. PRs are welcome though ??

Hi,
I’ve added another example which uses the swiper options filter here: https://github.com/goodwp/good-slider/blob/main/examples/filters.php and also added a notice to the FAQs in the readme.

• This reply was modified 3 weeks, 6 days ago by Fabian Todt.

I can confirm this in a quick test. The slide block does not support the align/alignWide block support because (if I remember correctly) it somehow messed with swiper styles.

But I tried to make the slide block work similar to the cover – it has most of the same block supports: background color, background image, spacing, dimensions, content position etc. Is there something you are missing?

You have specified several selectors

The code block above shows two “selectors” keys, because that were the two variants I tried. The first one directly sets one selector for the whole “typography” block support, the second one sets a root selector for the typography block-support and a special selector for the fontSize “subfeature” (as it’s called in the docs).

I’ve just tried it with Gutenberg 17.6.0 and also disabled Gutenberg and tried it again. None of the two ways above worked.

I also don’t see any code inside the block support apply functions that would use the selectors. That’s why I thought, maybe it’s just for global styles but not for single block instances?

Okay, thank you. But doesn’t the doc for getEditedPostAttribute “unsaved edit if one exists” suggest, that also unsaved edits will be returned?

See this GitHub issue – seems to be connected to using classic editor (which I am because I use it for flexible content fields). I remember there was a similar issue a while back.
In the GitHub issue there’s also a code snippet for a workaround via functions.php.

Yep, previews are working and showing the correct thumbnail. Thank you for the fast response.

Thanks for your reply.
I can’t – I only tested the update locally before deploying it to the live site. The error log was just a normal fatal error that the function is_user_logged_in called in restrict_media_library is not defined.

But I think I explained the problem well:
This plugin calls is_user_logged_in which is (according to documentation) a pluggable function and isn’t ensured to be loaded when you call it too early. Since this plugin calls it directly in a hook (pre_get_posts) and it’s not completely sure when this hook is called (because it get’s called in every WP Query not only in the main query) it should check if the function exists. Because some plugins (like the mentioned Broken Link Checker) make a WP Query before this pluggable function is included. Wheather that is correct behaviour of these plugins (or any other code which does it) to make a query before init is not important imho, because they do it (and I’ve seen it elsewhere as well).
Therefore a quick fix to be compatible with any plugin which does it and adhere to the documentation I encourage and ask you to wrap the call in a function_exists conditional – or as an alternative check if the current query is even the right query the plugin is after (as I see it’s only meant for media queries).

Thanks for your fast response. I’m with you regarding the pre_get_posts handling, there probably should be some kind of conditional check if the function is loaded and if it’s the right query – I’m gonna open a issue at the other plugin as well.

Best regards,
Fabian