Daryll Doyle
Forum Replies Created
-
Forum: Plugins
In reply to: [Safe SVG] Media Library previews don’t get updated when images get replacedHi @brad2dabone,
I would say that it sounds like your browser has cached the old SVGs based upon their name. Does it do the same if you clear your browser cache or open the media library in an incognito window?
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] Security / Vulnerability IssueA fix has just been approved with the WordPress team, please upgrade your installations to version
1.9.6
??Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] “Pending Full Review”Hi All,
The WordPress review has now gone through successfully and the plugin is available for download. Please make sure you all upgrade to the latest version
1.9.6
in order to be fully secure again!Thanks for your patience while we got this sorted ??
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] “Pending Full Review”Hi All,
Just as an update, a fix for the issue has been found and committed to the WordPress repository.
We now have to wait for the WordPress plugin team to review the fix and then it should be available for you to all update to.
Thanks for your patience.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] “Pending Full Review”Hi @skvandeusen,
That’s correct, there has been a bypass found for the underlying sanitiser. The WordPress team have disabled downloads until a fix has been confirmed.
I’m currently working on a fix and am hoping to have something ready by the end of the week, although we will have to wait for the WordPress team to review the fix before its re-enabled.
In my opinion, there’s no real reason to worry. It’s still more secure than any other SVG option out there (which offer no sanitisation) and a fix will be out shortly for the bypass found.
Sorry for the inconvenience and I hope we can get it sorted soon.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] Fatal ErrorHey @nonverbla,
Thanks for reporting this issue. I see what you mean ??
Whilst adding
__DIR__
fixes your use case, it does also break any time it’s used with symlinks. I will look into it and see what I can work out!Thanks again for the help.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] Creates wierd directory when using google storageThanks @georgerujoiu,
I’ve not personally used wp-stateless but I have used other offloading plugins and it seems to work fine with those.
I’ll look into this though, and see if I can find a solution going forward.
Thanks for the heads up!
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] wrong (decimal) svg image sizeForum: Plugins
In reply to: [Safe SVG] SVGs from photoshop not appearingHi @cmplesolutions,
I’m guessing that this is an issue with how you’re exporting the files. Photoshop is a raster-based editing program and generally, when I’ve seen it export SVGs, it simply wraps another image type (png, jpg, etc.) in an SVG wrapper, rather than truly exporting an SVG.
I would suggest trying it with an SVG exported from a vector-based editor, such as Sketch or Illustrator and seeing if you still get the same issue.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] Captions + SVGs w/ Decimal DimensionsHi @generalpeter,
I’m sorry to hear you’re having issues. If the plugin is installed and activated, then there should be nothing more you need to do.
If you’ve double-checked that it is and you’re still getting the issue, can you let me know a list of plugins and their versions, that you have installed on the site? I’m guessing there will be a conflict with one of them that’s overriding the Safe SVG upload handler.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] SVG image not showing in backend nor frontendForum: Plugins
In reply to: [Safe SVG] Wrong WordPress required versionHi @thepunisherbabi,
Thanks for pointing that out, you are indeed correct!
The plugin started off with 4.0 compatibility and I must have missed the update when adding in that function. I’ll get it updated on the next release.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] SVG Illegal string offset warning IS BACKHi @delaitec,
I’m not too sure if these plugins are to blame for the issue, as I’m not familiar with them, unfortunately. They could potentially have caused it if they tried to regenerate the image, but I can’t be 100% sure.
The modification wouldn’t have been CSS related, but it’s odd that it disappeared and came back after making an edit. Maybe there’s another plugin on your site that’s messing with images?
Unfortunately, saving the metadata for restore isn’t an option for this plugin. It would add far too much weight to the database in duplicated metadata and therefore would slow everyone’s sites down.
As we’re not seeing this on a huge amount of sites, I have a feeling it’s something within your WordPress stack that’s causing the issue. Can you try uploading a fresh SVG as before, but disable all plugins other than Safe SVG before you do so. Keep them disabled and refresh the page a few times. If you don’t see the issue, then the error is being caused by another plugin.
In that case, enable them one by one and refresh the page with the errors until you see it again, at that point, you should be able to narrow down the plugin in question.
Cheers,
DaryllForum: Plugins
In reply to: [Safe SVG] issue with svgClosing due to lack of response