Daryll Doyle

Great news @cag8f!

Thanks for letting me know ??

Ahh that’s perfect!

Glad you got it sorted and thank you for updating me ??

Cheers,
Daryll

Hi @pmaheepala,

The images should show in the media library, I’ve just tested on a couple of sites that I run and all seems OK.

I’m wondering if one of the other plugins is changing something. Is there any chance you can disable and extra media plugins and re-check the library. If that works then I can narrow down where the issue is and reach out to the plugin author for a fix!

Regards,
Daryll

Hey @cag8f,

Thanks for the bug report. I’ve located the issue and will push up a new version shortly with a fix.

As a quick question, have you or your host changed any of your PHP settings recently? Not sure why this would have just started but it needed fixing anyway.

Feel free to re-open this if version 1.5.1 doesn’t fix it for you!

Regards,
Daryll

Hey again @jumbo,

Unfortunately this is down to the underlying sanitisation library.

That SVG uses the use element to duplicate the corners and that element is currently stripped by the sanitiser, therefore only leaving the top two paths.

Work on getting the use element to work with the library is planned to start soon but I can’t give a definite date as to when it will be completed as of yet.

Regards,
Daryll

Hey @jumbo,

Glad you like the plugin and I’m happy to hear that you pre-sanitise your SVGs ??

Unfortunately there’s no way to turn off the sanitisation in the plugin as that’s the only reason for it being here.

If you’d really rather use this plugin over the others out there, it should be a fairly simple job to turn off the sanitisation by unhooking the following code on line 39.

add_filter( 'wp_handle_upload_prefilter', array( $this, 'check_for_svg' ) );

Whilst not the best workaround it should do the trick.

Sorry I can’t help more.

Regards,
Daryll

Closing due to lack of response. Please comment if you’re still having the issue and I’ll re-open the ticket.

Hey @mikrogramma,

Thanks for bringing this issue to my attention. I’ve now updated the library and both free and pro plugins to whitelist the role, aria- and data- attributes.

This should fix any of the issues you’ve been seeing but feel free to re-open the issue should it persist!

Cheers,
Daryll

Hi @mikrogramma,

Thanks for bringing this up!

This is something I have to admit I’d not thought about before but I’ll be happy to look into a fix for it. I’ve opened a bug on the underlying library whilst I work on a fix (https://github.com/darylldoyle/svg-sanitizer/issues/13) and as soon as I’ve got that working I’ll update the plugins to include the updated lib.

Cheers,
Daryll

Hi @ergu0015,

Can you show me the SVG that you’re trying to upload? I’ve not had any issues before with Illustrator files failing but it may be a <use> element issue.

You can either post it here or drop me an email at [email protected] and I’ll take a look at it.

Cheers,
Daryll

Thanks for the update Alex,

Glad you got it fixed.

Cheers,
Daryll

Yeah image/svg+xml is the correct mime type. I’ve just tested the plugin on another site I have and it’s still functioning correctly there so I’m guessing it’s an incompatibility somewhere.

Do you have any other plugins installed that affect the media library? If so can you try disabling them all and checking if it works then.

If that doesn’t work, can you let me know the site that you’re having issues with and the location of the SVG? Feel free to email this to me at [email protected] if that’s easier for you.

Hey!

Can you see the SVG in the media library or is it just a placeholder?

I’m going to make a wild guess and say that either the SVG corrupted which I’ve not seen very often or that your server is serving SVGs with an incorrect mime type.

If you open the SVG on your server directly in your browser can you see it then?

Cheers,
Daryll

Hi Immánuel,

Yeah, I see no reason this wouldn’t be possible. Initially it wasn’t added as it’ll only have an effect on scripts loaded from your domain and in my experience there’s usually only a couple, which wouldn’t make a huge amount of difference.

I can always look into it though and give you an update when I’ve tested the idea.

Cheers,
Daryll

Hi @alriksson,

Any chance you can upload a couple of them somewhere for me to test with as I’m not 100% sure what you mean.

Alternatively feel free to email them over to me at [email protected] and I’ll try and take a look ASAP.