encirclesupport

I’ve managed to get this working on 6.4.3

I replaced the samesite_setcookie function for the following code:

function samesite_setcookie($name, $value, array $options) {
setcookie($name, $value,$options);
}

It looks like the original code was wiping out other cookies set in the same request. Just replaced with the stock php setcookie function.

I’ve found the line of code that is problematic:

good_old_twitter_widget.php:

Line 340

   if ($options['skip_text']!='' || $options['skip_replies'] || $options['skip_retweets']) {
      $max_items_to_retrieve *= 4;
    }

So it’s a fair guess that 4* the number of tweets will cover all actual tweets. However this assumption doesn’t hold if there are a high number of retweets. Suggest implementing ‘retry until all tweets are counted in logic loop’ perhaps?