ellimerino

This is great, thank you!

Seriously? anyone can inspect the code and tell you the conditions where it will fail and you ask that?

The RegEx does *not* look for only the domain that hosts the form. It matches *any domain*, and the domain matching RegEx does not match all valid tracker domains, only domains of the form x.y.z. So it will break on perfectly valid tracker domains where there are more than 3 components to the domain name, like tracker.company.co.uk or tracker.department.university.edu. There are also likely corner cases where you have 2 component domain names (e.g. tracker.local) for test servers too.

I would suggest one of the following:
1) Match on any domain (what the code currently tries to do). Modify the RegEx to allow any valid domain (an arbitrary string containing a-z, A-Z, 0-9, – and .)
2) Match on only the exact tracker domain. Get the tracker domain from Pardot and drop it into the regex after escaping any special characters like . and -.

Cliff,

Your RegEx only works on domains that have 3 components.

e.g. it’ll work on https://www.xyz.com but not xyz.com

because your RegEx explicitly looks for <string>.<string>.<string>

I don’t know why you are doing this when you don’t care what the domain is. All you care about is capturing the path that comes after the domain.

So I recommend the following regex:

/(http|https)\:\/\/[a-zA-Z0-9\-\.]+(\/\S*)?/

This matches any domain, regardless of what it is and how many dotted components it has, and captures the path that comes after the domain.

However, your proposed regex also doesn’t work for domains that don’t end in 2 or 3 characters. I’d propose the following:

/(http|https|ftp|ftps)\:\/\/[a-zA-Z0-9\-\.]+(\/\S*)?/

Yeah, we are seeing this too. Thanks for the fix.

… and I also have the same issue. Only on some posts, not all of them.

Spent some time debugging — looks like you are looking for the Etag from Github and/or Dropbox. But neither site sends the Etag field in their HTTP response headers (when I try it, at least).

If your plugin doesn’t get an etag, then it just stops and puts up a blank error form.

Thanks for the reply — figured out how to get control over what size of image is displayed with help from the WP Types plugin support team.

Here

Of course now… the image that is displayed when I click on a thumbnail (to go to the individual image page) only shows a small image not the original size. Can’t figure out how to change that…

Thanks for the second quick response — that worked!

Thank you for the fast response — and that is an excellent solution.

That was it! I would never have figured that out, so thanks very much!

That’s just the formatting of this forum. It deleted the double space! I will try using backticks…

. is the search string, . is the replace string.

It doesn’t work for me — blog posts totally unaffected. So I wonder what is different?