eigood

So, yeah no. If I switch to “normal” mode, then when I do page=”/path/_nav”, I actually get a re-insertion of the *current* page I’m looking at. If I stay with “legacy”. and use my patch, I actually get the referenced page. So normal mode doesn’t look at given page attribute at all.

Looking further at the code, line 426 contains the same security check as mentioned previously, but in this case, it happens *above* the wpip_insert_method condition.

That’s got it; it wasn’t clear that your suggestion was to update in the global settings area, instead of just setting a new option on the shortcode itself.

I take it back, that does *not* work.

wpip_insert_method=”normal” works, but can’t users themselves set that parameter inside post content areas?

diff --git a/www/wp-content/plugins/insert-pages/insert-pages.php b/www/wp-content/plugins/insert-pages/insert-pages.php
index b462d24c..9412e583 100644
--- a/www/wp-content/plugins/insert-pages/insert-pages.php
+++ b/www/wp-content/plugins/insert-pages/insert-pages.php
@@ -746,7 +746,7 @@ if ( ! class_exists( 'InsertPagesPlugin' ) ) {
                                if ( have_posts() ) {
                                        $can_read = true;
                                        $parent_post_author_id = intval( get_the_author_meta( 'ID' ) );
-                                       foreach ( $posts as $post ) {
+                                       if ($parent_post_author_id) foreach ( $posts as $post ) {
                                                $post_type = get_post_type_object( $post->post_type );
                                                if ( ! user_can( $parent_post_author_id, $post_type->cap->read_post, $post->ID ) ) {
                                                        $can_read = false;

`

• This reply was modified 2 years, 5 months ago by eigood.

I can do some work on this; for 0.1.7.1, I also had implemented a background type fetch, as originally it would block the main php process, and under heavy load, when the cache became invalid, there would be a storm of updates. I did it with a system-level cron, tho.

The timeline required by the client needs me to move on, but I can work on this in my spare time.

At least 1.c is bad, for a wordpress plugin. But actually, section 1 says you can charge, but then 1.c rescinds that. Very odd. But we must err on the side of caution, so I agree that IEX is out.

Or: https://iextrading.com/developer/docs/

I’d rather not, as the author has said it’s not allowed for an official plugin. I want to honor his recommendation.

However, it wasn’t that hard to figure out the correct fields to request, and to then parse the csv and convert it to stdClass instance.

I’m currently looking at https://www.alphavantage.co/, but this requires an API key. That’d mean the plugin would need to have a config value for that key.

Bother. Then my fix will work for my client for the weekend, at least. I’ll look more next week.