eek

Yes, if I upload the file in the media library there’s no issue with it.

I understand this behavior for elements the browser doesn’t know the Aspect Ratio, but for video blocks, it shouldn’t have an issue.

Also, another curious thing, on the link that I’ve sent yesterday, I now see the “responsive” video now appears and also has the proper width / height and so with the “Default” one.

Yeah, I think removing the Layout control is a good thing.

Here is an example: https://thebleedingedge.tech/2020/08/12/amp-video-test/

I finished my function.

Unfortunately if I use the add_action facebook me will return me an oauth exception (not sure if it’s from the cookie parsing or the sfc_remote, even weired is that it works before).

So this is the function

function sfc_login_register_user( $data ){

		if ( empty( $data ) ) return 0;
		if ( array_key_exists( $data['error'] ) )  return 0; 

		$username = str_replace( ' ', '', strtolower( $data['first_name'].".".$data['last_name'] ) );
		$username = sanitize_user($username, true);

		$counter = 1; //Check for Unicity
		if ( username_exists( $username ) )
		{
			do
			{
				$finalname = $username;
				$counter++;
				$finalname = $finalname . $counter;
			} while ( username_exists( $finalname ) );
		}
		else
		{
			$finalname = $username;
		}

		if ( !email_exists( $data['email'] ) ) {
			$random_password = wp_generate_password( $length=12, $include_standard_special_chars=false );
			$user_id = wp_create_user( $finalname, $random_password, $data['email'] );

			wp_update_user(
				array (
					'ID' => $user_id,
					'first_name' => $data['first_name'],
					'last_name' => $data['last_name']
				)
			);
			update_usermeta( $user_id, 'fbuid', $data['id'] ); 

			$user = new WP_User( $user_id );
			if( is_user_logged_in() ) {
				wp_redirect( home_url() );
				exit;
			}
		} else {
			echo "Email already exists.";
		}	

	}

On sfc_login.php on line 169, I have replaced the do_action('sfc_login_new_fb_user'); // TODO hook for creating new users if desired
with

$succes = sfc_login_register_user($data);
if ($succes == 0) { wp_redirect( site_url( 'wp-login.php', 'login' ) ); }

Line 2 is there because on the first login $data from sfc_remote is empty, and if I refresh it’s ok. Weird.
It works, also, I added “username,first_name,last_name” to fields from sfc_remote on line 155

??

If anyone finds it useful, I’m glad ??

I know changes are sometimes necesary, but having backward compatibility is always a huge plus, especially since more than 90% of your plugin users will be just that. Users. They will not have the necesarry skills to modify their themes to make it work again. But yeah, you could say that if they didn’t modifiy their widget’s php’s, they’ll be fine.

Also, I’m using lwa with otto’s simple facebook connect, and I could share the code snippet to include a login button to your widgets, also I could make some options in the option page for users to include / exclude button if they have SFC installed or not. If you’d want to include them in a next release or something ??

Thanks,
Eek

You can force via css using

.widget .post-ratings img{width:10px !important;}

Your widget should output the “widget” class, so including this css snippet, would overwrite only under the .widget class ??

Make a theme with the biggest stars there are (to use them on single.php) and on home.php incluse in your stylesheer a snippet of css to make your stars smaller.

For example:

.post-ratings img{width:10px;}

That should work and make your stars different size ??

Hmm… To see if it’s called or not, try adding a function in the functions.php

function removeres(){
   echo "remove_action";
}

And then try calling it in the footer: removeres();

See if that shows anything ??

functions.php is always called.

But I don’t understand how you don’t get a parse error…

Declaration of the variable should be something like this:

global $removeres;
$removeres = 'remove_action: ';

Try now that echo ??

I had the same problem… Don’t know how I managed to forget to reset the query ?? What a headache!

Thanks mtekk >:D<

I had the same problems ?? But you can quickly fix it by going at the plugin folder, open editable-form.php and change the line
<form action="<?php echo get_permalink().'#comment-'.$editable_comment->comment_ID; ?>" method="post" id="dialog_commentform" onsubmit="return dialog_validate()">

to

<form action="<?php echo get_permalink().'#comment-'.$editable_comment->comment_ID; ?>" method="post" id="dialog_commentform" onsubmit="dialog_validate()">

That is simply remove the “return” in from of dialog_validate() on the onsubmit ??

Set in php.ini, memory_limit = 64M; and that will probably fix your problem ??

Had the same problem, define(‘WP_MEMORY_LIMIT’,’64M’); didn’t work, but setting memory_limit in phpini to 64M did work ??

So, php.ini, define memory_limit = 64M;