Drivingralle

@kittmedia Haben den Patch auf den beiden Websites wie oben verlinkt angewendet und es sieht deutlich besser aus.

Wenn das Verhalten dem entspricht was der Plan war würde ich sagen, ein erfolgreicher Patch.

Added some logging:

error_log( var_export( '$args before', true ) );
		error_log( var_export( $args, true ) );

		// the default dimensions are useless
		if (
			! empty( $args['height'] ) && $args['height'] === 1000
			&& ! empty( $args['width'] ) && ( $args['width'] === 750 || $args['width'] === $GLOBALS['content_width'] )
		) {
			unset( $args['height'], $args['width'] );

			$dimensions = $this->get_oembed_dimensions( $output );

			if ( ! empty( $dimensions ) ) {
				$args = array_merge( $args, $dimensions );
			}
		}

		error_log( var_export( '$args after', true ) );
		error_log( var_export( $args, true ) );

		// add two click to markup
		return $this->get_output_template( $embed_provider, $embed_provider_lowercase, $output, $args );

Log output:

[02-Mar-2023 21:25:30 UTC] '$args before'
[02-Mar-2023 21:25:30 UTC] array (
  'width' => 580,
  'height' => 870.0,
  'post_id' => 41,
  'embed_title' => '?Tim Urban: Tribalism, Marxism, Liberalism, Social Justice, and Politics | Lex Fridman Podcast #360“',
  'embed_url' => 'https://www.youtube.com/watch?v=GkZz2I6sK08',
  'strip_newlines' => true,
)
[02-Mar-2023 21:25:30 UTC] '$args after'
[02-Mar-2023 21:25:30 UTC] array (
  'width' => 580,
  'height' => 870.0,
  'post_id' => 41,
  'embed_title' => '?Tim Urban: Tribalism, Marxism, Liberalism, Social Justice, and Politics | Lex Fridman Podcast #360“',
  'embed_url' => 'https://www.youtube.com/watch?v=GkZz2I6sK08',
  'strip_newlines' => true,
)

Hey!

We have broken aspect ratios too.

Demo: https://news.wekiwi.de/2022/10/19/wekiwi-in-videos-erklaert/
Also here: https://blog.drivingralle.de/

Some logging I have made right before the inline style is generated:

$args array (
  'width' => 580,
  'height' => 870.0,
  'post_id' => 41,
  'embed_title' => '?Tim Urban: Tribalism, Marxism, Liberalism, Social Justice, and Politics | Lex Fridman Podcast #360“',
  'embed_url' => 'https://www.youtube.com/watch?v=GkZz2I6sK08',
  'strip_newlines' => true,
)
$GLOBALS['content_width'] 580

If I remove the line everything looks fine for my use cases:

aspect-ratio: <?php echo esc_html( $args['width'] . '/' . $args['height'] ); ?>;

Anything I can check to help debugging the problem?

Greetings
derRALF

• This reply was modified 1 year, 8 months ago by Drivingralle.

Have the same problem.
Looking forward to a maintenance release to fix this bug.

Greetings
derRALF

Hey!

I get the same message in my errors logs.
Would be great to get a maintenance release to remove this notice.

Greetings
derRALF

Hey!

No problem waiting for the regular release. Happy to hear that a fix is already on the way.

Greetings
derRALF

Looking forward to the new version!

I’m using WP for many use cases. One of them is internal communication inside of companies on none-public websites (logged-in-only).

Inside this systems the users have personal dashboards (in frontend) that shows all related things. Sometimes this are even a mix of the two ideas I described above.
For example: All the media they created/added to the system: books and movies or cars and motobikes.
Or just a list of on post type they have added.

If I come across more feature ideas I’ll add them below

I also get this error.

Hope the team behind the plugin can fix it soon.

I’ll start the process to allow the takeover inside my compay. So later this year we can do it

Greetings
derRALF

Now I have found the setting.
Thanks a lot ??

Hey!
Looking forward to the change.

Greetings
derRALF

Great news!
Thanks!

A fix that in general removes the REDUX-Spam would be great.

Hey!

As I place the yoast breadcrumbs block inside the content of my website the styling of that block doesn’t match the styling of the regular breadcrumbs, generated by theme.

I specifically mean the styling as a bock is placed inside the contetn of a page or post.

Greetings
derRALF