donbowman
Forum Replies Created
-
Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] Embed is defaulting to hiddenHmm, ths might not be a theme thing.
in wp_filter_oembed_result() it adds this. But perhaps i need to add my own site in as a trusted oembed provider.
Forum: Plugins
In reply to: [Gutenberg] Form Block: insecure endpoint (Chrome)In the ‘view.js’ for the block of /wp-content/plugins/build/block-library/blocks/form, it does:
document.querySelectorAll('form.wp-block-form').forEach(function (form) {
// Bail If the form is not using the mailto: action.
if (!form.action || !form.action.startsWith('mailto:')) {
return;
}so indeed it forces an action of mailto: or it won’t post.
The insecure… an https site cannot use mailto: (tons of posts online about this).
I believe this is a false check above, we don’t really want mailto (e.g. opening the mailer), we want http post.
Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] How to change editor width?I don’t see that option on ‘Page’, only on ‘Post’.
E.g. if i say ‘new post’, group gets that option, but ‘new page’, it does not.
Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] How to change editor width?the group is set to full width, and it is the group w/ the background colour.
when viewing the post, the group expands w/ colour to the entire width, but not when in the editor.
Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] How to change editor width?I have this as a simple page/
<!-- wp:group {"backgroundColor":"light-grey","layout":{"type":"default"}} -->
<div class="wp-block-group has-light-grey-background-color has-background"><!-- wp:paragraph -->
<p>I am a paragraph in a wide container.</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->
I then see this:Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] How to change editor width?Its not resolved, i’m not sure what to do.
why should it matter if i’m grouped or not? My objective is to make the editor match the published content, but it doesn’t in width. when i have a full width container/group, it shows live but not in editor.
- This reply was modified 2 months, 2 weeks ago by donbowman.
Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] How to change editor width?you can see i have diagnosed it above.
I have the carousell in a reusable block.
You have code calling has_blocks(gutslider/logos…).
has_block does not look into reusable blocks, so your check fails.
To fix it, you will need a helper function in gutslider_assets to check by calling parse_blocks.
see also https://kybernaut.cz/en/clanky/problem-solved-check-for-has_block-inside-reusable-blocks/
note this is super inneficient in this code base since you call it multiple times, and its very slow. So i think you would instead look for gutsliders/*, or use a single regexp rather than multiple block_parse/walks.
if( ! is_admin() && ( GutSlider_Assets::enhanced_has_block( ‘gutsliders/content-slider’ ) || GutSlider_Assets::enhanced_has_block( ‘gutsliders/any-content’ ) || GutSlider_Assets::enhanced_has_block( ‘gutsliders/testimonial-slider’ ) || GutSlider_Assets::enhanced_has_block( ‘gutsliders/post-slider’ ) || GutSlider_Assets::enhanced_has_block( ‘gutsliders/photo-carousel’ ) || GutSlider_Assets::enhanced_has_block( ‘gutsliders/logo-carousel’ ) || GutSlider_Assets::enhanced_has_block( ‘gutsliders/videos-carousel’ ) ) ) {
Forum: Plugins
In reply to: [WP-Stateless - Google Cloud Storage] migration issues with 4.0thank you, will try.
on first look it seems you just unconditionally supress error messages? Is this necesarily wise?
Forum: Plugins
In reply to: [WP-Stateless - Google Cloud Storage] migration issues with 4.0I’ve also observed…
MySQL [www_database]> select count() from wp_stateless_file_sizes; +----------+ | count() | +----------+ | 11765 | +----------+
that this table is larger than the number of files i have (~2900files).
Forum: Plugins
In reply to: [Nelio AB Testing] cloud proxy 403i did set up the endpoint, and then instrumented the ‘proxy’ function in the php to see it was called (that’s where the output is from).
I have turned it off for now.
i used /ab/api i think. i verified the endpoint was shown in the wp-json output alongside the others (in the namespaces object). I verified it called the proxy function, and then sent that request to the upstream, which returned the 403.
the 403 was returned from api.nelioabtesting.com / cloudfront, as was the reason.
curl –cookie ver=staging https://www.agilicus.com/wp-json/ | jq | more
you can see the ‘ab’ namespace on my staging site (which is routed via blue/green testing on this cookie).
- This reply was modified 9 months, 1 week ago by donbowman.
Forum: Themes and Templates
In reply to: [Twenty Twenty-Four] High CLS in navigation block on mobilethis might be related:
so although that might help, the performance is really quite poor here.
me typing in a paragraph can’t possible change css somewhere, and having some javascript fire and then recalculate other blocks for every keystroke, i’m not sure why its need.
OK, to reproduce:
- https://playground.wordpress.net/?plugin=blocks-css&plugin=ultimate-addons-for-gutenberg&php=8.3&wp=6.4&storage=none&php-extension-bundle=kitchen-sink
- Edit Site
- Create synced pattern ‘form’
- Add a ‘form’ block from uagb, accept default
- Create a page
- create a paragraph w/ a few words
- insert the ‘form’ synced pattern
- in console, run ‘monitorEvents(window);’
- type a key in the paragraph from #6
You will observe a constant stream of ‘Updated Block: uagb/forms’ messages in console, one for each keystroke.
Also, the system will be exceptionally slow.