craig030
Forum Replies Created
-
Forum: Plugins
In reply to: [WooCommerce] Product pages – Google Translate unrecognized expressionHi Saif,
That makes complete sense and I understand exactly what you are saying here, the only part I don’t understand is. I have sentry.io set up on the site to notify me of errors, if Google basically takes a snapshot of the site and then creates a new URL with the translated document provided by their service, I’m not sure how sentry receives this error as it’s affectively a new URL / domain?
Any ideas?
Many thanks,
Craig
Forum: Plugins
In reply to: [WooCommerce] Product pages – Google Translate unrecognized expressionI raised this in Google’s community forum and had a response from someone (I don’t believe they are a Google representative but a Platinum Product Expert)
This is a compatibility issue with WooComerce that has also been raised in the Ads community; You should contact WooComerce; They should code THEIR website to be compatible with Google, not the other way round...
Do you know if this issue is being raised and looked into?
Forum: Plugins
In reply to: [WooCommerce] Product pages – Google Translate unrecognized expressionHi Saif,
Thank you for the quick response, appreciate the help and support here.
I understand that images are not translatable but I can see the images are still there on the <img> element and even through the Google translate link they are viewable
It seems to be linked to
/wp-content/plugins/woocommerce/assets/js/frontend/single-product.min.js?ver=7.5.1
line 16
e.find(t.attr('href')).show()
Not sure if this has anything to do with it from WC side?
Many thanks,
Craig
Forum: Plugins
In reply to: [Gutenberg] Deprecated extended blocksHi Ryan,
Thanks for getting back to me, no problem here is a gist of the code. It’s to extend the cover block to wrap it with an
<a>
element so I can add links to the block.https://gist.github.com/craig030/80d6f817ac416a9691392c144eb2eb11
I don’t have the deprecation part added to this gist but maybe you can make a suggestion with my comments before?
Appreciate your help thank you!
Many thanks,
Craig
Forum: Plugins
In reply to: [Gutenberg] Deprecated extended blocksHi Ryan,
Thank you for getting back to me, I tried this but sadly it still gives me a validation error as it is not picking up the change in the editor.
I’ve also slightly changed the code
<a style="padding: 0;" className={element.props.className} href={href.url} rel={rel}> {element} </a>
It didn’t like the variables either,
element
comes from theblocks.getSaveElement
hook and in the deprecation, we are writing code for the save() function as you would in a custom block rather than extending. Does this mean setting up deprecation won’t be possible when extending blocks?I did strip out all the dynamic data and tested with my original class names and that’s when I was still getting validation errors. Any ideas?
Many thanks,
Craig