corvannoorloos

Forum Replies Created

Viewing 11 replies - 1 through 11 (of 11 total)
  • corvannoorloos

    (@corvannoorloos)

    The first turned out to be the easiest solution:

    add_filter( 'gettext', 'username_or_email_login', 10, 2 );
function username_or_email_login( $translation, $text ) {
	global $pagenow;
	if ( 'wp-login.php' === $pagenow ) {
		if ( $text === 'Username' ) {
			$translation = __( 'Username or email', 'wp-email-login' );
		}
		if ( $text === '<strong>ERROR</strong>: The username field is empty.' ) {
			$translation = __( '<strong>ERROR</strong>: The username or email field is empty.', 'wp-email-login' );
		}
	}
	return $translation;
}

    Since the language files will have to be regenerated anyway I’ve changed “email” from the first string and “username or email” from the second string to all lowercase.

    corvannoorloos

    (@corvannoorloos)

    On second thought, equal should be identical:

    if ( ! is_user_logged_in() || 'wp-login.php' == $pagenow ) {

    should be

    if ( ! is_user_logged_in() || 'wp-login.php' === $pagenow ) {

    corvannoorloos

    (@corvannoorloos)

    Not entirely sure if this reply should have its own thread, but the main ‘Username’ label could be filtered by something like this:

    add_filter( 'gettext', 'email_login_username_label', 10, 2 );
function email_login_username_label( $translation, $text ) {
	global $pagenow;
	if ( ! is_user_logged_in() || 'wp-login.php' == $pagenow ) {
		if ( $text === 'Username' ) {
			$translation = __( 'Username or email', 'wp-email-login' );
		}
	}
	return $translation;
}

    I’m not really sure about the error notices however (and haven’t really paid attention to yet).

    I believe they can be included in the same filter, but it might be better to use the authenticate filter for these (which is the part I’m not really sure about).

    Thread Starter corvannoorloos

    (@corvannoorloos)

    Hi esmi,

    Thank you for your quick reply.

    That’s unfortunate.

    Anyway, thanks again!

    In short, yes, that’s its only purpose.

    I believe its only issue is/was (can’t remember anymore, as I’m not using any comment system) it isn’t/wasn’t rewriting the ARIA roles in the comment form.

    Currently using this plugin with WordPress 3.4.1-alpha-21081 and it works pretty great, without any errors. (html support would be really great however!)

    To have everything look nice and tidy. (and similar)

    Just a small snippet from things between <head></head>:

    <link rel="alternate" type="application/rss+xml" title="Lorem ipsum ? Feed" href="https://mydomain.tld/default/feed" />
<link rel="alternate" type="application/rss+xml" title="Lorem ipsum ? Comments Feed" href="https://mydomain.tld/default/comments/feed" />
<link rel='stylesheet' id='admin-bar-css'  href='https://mydomain.tld/default/wp-includes/css/admin-bar.css?ver=3.4.1-alpha-21081' type='text/css' media='all' />
<link rel='stylesheet' id='fonts-css'  href='https://fonts.googleapis.com/css?family=Open+Sans%3A300italic%2C400italic%2C600italic%2C700italic%2C400%2C300%2C600%2C700&ver=3.4.1-alpha-21081' type='text/css' media='all' />
<link rel='stylesheet' id='twentytwelve-style-css'  href='https://mydomain.tld/default/wp-content/themes/build/style.css?ver=3.4.1-alpha-21081' type='text/css' media='all' />
    Thread Starter corvannoorloos

    (@corvannoorloos)

    Thank you for your reply. Looking forward to it!

    Thread Starter corvannoorloos

    (@corvannoorloos)

    Just rewrote above to

    add_filter( 'admin_init', 'admin_menu' );
/**
 * Removes the admin menu theme and plugin editor links
 */
function admin_menu() {
  remove_submenu_page( 'themes.php', 'theme-editor.php' );
  remove_submenu_page( 'plugins.php', 'plugin-editor.php' );
}

    , and everything’s working fine again.

    Thread Starter corvannoorloos

    (@corvannoorloos)

    First of all, sorry. I’ve listed it as a bug quite being quite sure I didn’t have something interfering with this function.

    It seems I do have something, though it’s a bit awkward…

    I’m currently using below snippet to hide my theme and plugin admin menu editor links.
    Disabled, it’s showing the icon. Enabled, it’s showing like the screenshot.

    add_filter( 'parent_file', 'admin_menu' );
/**
 * Removes the admin menu theme and plugin editor links
 */
function admin_menu() {
  global $menu, $submenu;
  remove_submenu_page( 'themes.php', 'theme-editor.php' );
  remove_submenu_page( 'plugins.php', 'plugin-editor.php' );
}

    Not entirely sure now if it should be listed as a bug or not.

    Thread Starter corvannoorloos

    (@corvannoorloos)

    Ehm, weird… It’s showing on some sites, and not showing on other. After debugging this further I’ll come back on this asap.

Viewing 11 replies - 1 through 11 (of 11 total)