markcummins
Forum Replies Created
-
Forum: Alpha/Beta/RC
In reply to: Calling ‘have_posts()’ in a custom block returns falseHi, sorry I didn’t check back up on this and thanks for the response. For me, I used rewind_posts() before calling have_posts(), and that solved the issue that I was having. As you say though, I shouldn’t be calling it twice anyway.
I just wanted to highlight it before wp 6.4 launched in case it was a bug, but if it’s expected behavior, then it makes sense to close the issue.
Great, thank you for the response. I think I’ll wait for the official update rather than messing around with the code myself, but glad to hear that it will be fixed. Thanks!
Great, good to hear it will be fixed soon. Thanks for the update Mehedi
p.s. my temporary fix is to make the following changes in in RTMediaNav.php
1.
Delete this line
$bp->version = floatval( $bp->version );
2.
replace this line:
if ( isset( $bp->version ) && $bp->version > '2.5.3' ) {
with this line:
if (isset($bp->version) && version_compare($bp->version, "2.5.3", 'gt')) {
- This reply was modified 2 years, 3 months ago by markcummins.
@thebengalboy the issue is in the file
/app/main/controllers/template/RTMediaNav.php
. There is a function which registers the menu calledbp_core_new_subnav_item
.The code doesn’t reach this function because of the following check:
if (isset($bp->version) && $bp->version > '2.5.3')
I know that the comparison operators changed between php 7.4 and 8, so the check here returns true in PHP 7.4, but it returns false in PHP 8, and that causes the error.
Maybe it should be using the version_compare function to check this, as I see that function is also used elsewhere in rtMedia
Forum: Plugins
In reply to: [bbPress Votes] Changing Score TextAlso, it would be great to be able to move score to the right of the button.
Cool, they are Dev4Press Updater V 3.0.3 and GD bbPress Toolbox 4.0.2 which I haven’t got round to updating, thanks.
I have bbPress ToolBox and Dev4Press Updater. Once these are disabled, there is no error.
Forum: Plugins
In reply to: [BuddyPress Multilingual] Please fix this bug in uri_filterSame for me in english
/members/dbowen/