chadatgiftcards
Forum Replies Created
-
Forum: Plugins
In reply to: [Rackspace CloudFiles CDN] ContributingYou might not think that, however from an enterprise level where you have many thousands of images being maintained by a Marketing department it matters. For a small company, you are more likely than not correct. However, when you start working with larger chains of command one must think on that scale. I could never approve a plugin like this knowing it will remove our media as soon as it’s uploaded.
When you get that feature done please let me know. I would like to take another look at your plugin (though you are posting in someone else’s plugin right now).
Forum: Plugins
In reply to: [Rackspace CloudFiles CDN] ContributingWhy did you comment this out?
// Verify file was successfully uploaded // if (isset($_SESSION['cdn']->api_settings->remove_local_files)) { if (verify_successful_upload($file_to_upload) == true) { @unlink($file_to_upload); } // }
Most people don’t want their files removed immediately upon upload. What if CloudFiles isn’t going to be used and we switch to S3? We just lost all our media. If you put that option back into the system, I will make the switch over to your plugin. Otherwise I am going to keep what I have because it works and doesn’t remove from my local system constantly.
Forum: Plugins
In reply to: [Rackspace CloudFiles CDN] ContributingI went through the current codebase and made quite a few changes. These changes brought it up to the standards for CloudFiles and PSR2 formatting.
You can view the code at:
https://github.com/giftcards/rackspace-cloudfiles-cdnI tried to send a PR, but found that the clone (https://github.com/wp-plugins/rackspace-cloudfiles-cdn) was actually a read only instance of the repository and not maintained by you.
Let me know if you have any questions, as it stands right now your code doesn’t set the correct headers for images. Plus, we really need to consider how to handle when OpenCloud updates. The plugin is well out of date from it (they are up to 1.9.3).
Lastly, I implemented the ability to be notified from WordPress when it had to “crunch” the image to make smaller ones. It will upload the main one they upload, and then find the scaled versions and send those to CloudFiles as well. It bypasses the need to upload everything to CloudFiles initially.
Tested with:
Multi-site (5 sites)
WordPress 3.5
Single file upload
Multiple file upload
Large images, single and batch that are scaled
Small images, single and batch that are not scaledRead the last commit and I explained what I had to change.