casper
Forum Replies Created
-
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] nested accordianHI Vishal. I see what you mean. The accordion JavaScript is something we have been considering overhauling, but I can’t promise if or when that will happen, because it means a full rebuild of that logic. Until then, I’m afraid nested accordions within accordions won’t work properly. I did reach out to my co-developer and will report back here if he thinks of any workarounds or fixes. Expect to hear from my in the next day or two.
Forum: Plugins
In reply to: [Dynamic Conditions] Site blown after update to 1.7.01.7.0 is causing this fatal PHP error for me:
“PHP Fatal error: Uncaught TypeError: DynamicConditions\Admin\DynamicConditionsAdmin::addConditionFields(): Argument #1 ($element) must be of type Elementor\Element_Base, ElementorPro\Modules\Popup\Document given, called in /wp-includes/class-wp-hook.php on line 324 and defined in /wp-content/plugins/dynamicconditions/Admin/DynamicConditionsAdmin.php:81”
My site does have an Elementor popup on all pages. The popup gets triggered by clicking the mobile menu icon, but that does not use dynamic conditions.
Update: I see version 1.7.1 just came out. I updated to that and now everything loads fine. WOW that was fast.. THANK YOU!!
I have this exact same issue in version 5.0.8, installed yesterday. I turn off the floating switch, save changes. When it is done saving, I reload the /wp-admin/admin.php?page=wp-dark-mode#/switch settings page and it shows the floating switch as enabled. I can’t disable it; it does not save this setting.
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Huge accordion icons on iPhoneIt looks like you’re using the plugin’s minimal theme, which means all of the plugin’s CSS is left out / not applied. The minimal theme is meant for developers who want to supply all the CSS themselves.
You could switch to one of the other plugin themes. If you stay with the minimal theme, adding the following CSS should fix it for you:
.plethoraplugins-accordion.plethoraplugins-theme__minimal .pds-accordion__icon?{ width: 1rem; height: 1rem; }
Thanks for flagging. I was able to reproduce this; that popup warning is produced by WordPress, but possibly caused by some interaction between our plugin and WordPress. ?I can’t say with certainty that’s the case. I have also encountered that warning with some core blocks e.g. paragraph blocks. In other words, it may just be a core WP thing you can safely ignore.
For now, just ignore the popup warning. It’s something we’ll look into next time we do a release. We usually bundle a few fixes together at a time. I can’t give an ETA on that, but suffice to say it has been noted and will get attention with the next release.
Forum: Reviews
In reply to: [Plethora Plugins Tabs + Accordions] Broken on my siteWe are using it with WordPress 6.4.1 without issues. The plugin has not needed any updates since 8/23, which is not all that long ago. The demo at https://plethoraplugins.com/tabs-accordions/ still works, and our site is fully up to date. I am having a look at your site to see what might be going on.
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] URL Variable breaks accordionHappy to help!
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] URL Variable breaks accordionI sent you an email reply with possible fix
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] URL Variable breaks accordionSomehow or other you seem to be experiencing behavior we cannot replicate, so I suspect it’s some unrelated JS that is tacking on those ?hash= variables at the end of the URL (where it should be taking the hash into consideration, not just adding the ? to the end of the url).? An example, non-working page would be easier to understand of course, but we tested it out on our own demo page and both the initial load and clicking around both tabs and accordions worked fine with a URL parameter set:
https://plethoraplugins.com/tabs-accordions/?test=1#v_maecenas_hendrerit
Feel free to send me a demo URL via our contact form at https://plethoraplugins.com/contact/, so that we can see the issue first-hand. That will help a lot. ThanksForum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Loading of every view is wastfullAbsolutely! Glad to hear it
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Further settingsThanks for the update, Hans-Gerd
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Further settingsHi Hans-Gerd,
Our plugin’s focus has been on not getting in the way of developers, and letting themes affect the tabs’ styling. The idea has been to use minimal CSS and let developers add any additional CSS they want.
However, I get your point that hover, focus, active styling would be handy to have in the admin controls somewhere, since not everyone wants to dive into code. We are considering it for the pro version.Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Loading of every view is wastfullWe just released 1.1.1, which changes the plugin so it loads the JS only when needed (by default). The plugin has an option (in the admin settings) to force the JS to run on all pages, but that option is disabled by default.
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Loading of every view is wastfullThanks for alerting us to this. We’re looking at it and plan to address this in the next release, but yet can’t say when that will be.
Forum: Plugins
In reply to: [Plethora Plugins Tabs + Accordions] Hash link for accordion@apin13 This has been fixed in version 1.1.0, just released.