cabader

Thank you for your quick response. I installed the updated plugin, and have had no further Undefined variable messages in the debug log.

Thank you!

I am also experiencing the following error in the debug log:

[15-Apr-2020 15:56:35 UTC] PHP Deprecated: contextual_help is <strong>deprecated</strong> since version 3.3.0! Use get_current_screen()->add_help_tab(), get_current_screen()->remove_help_tab() instead. in */wp-includes/functions.php on line 5088

WP Realtime Sitemap version: 1.5.7
WordPress version: 5.4
PHP version: 7.2.29

A search of all plugins on the site for the use of ‘contextual_help’ revealed the following:

*\wp-realtime-sitemap.php (1 hit)
	Line 46: add_filter('contextual_help', array(&$this, 'addHelp'), 10, 2 );

Could you please advise if/when the plugin will be updated so it no longer generates this error message?

Thank you!

Thank you, @mikeverduin. The workaround worked for me too.

I am hoping that the maker of BackWPup will have a more permanent solution in their next update.

Thank you!

I am also experiencing this issue.

Here is the error message in the debug log:
PHP Deprecated: Non-static method BackWPup_Admin::admin_css() should not be called statically in */wp-includes/class-wp-hook.php on line 287

BackWPup version: 3.7.1
WordPress version: 5.4
PHP version: 7.2.29

Just a quick postscript that after updating WP Rocket to the newest version today (3.4.4), this issue completely resolved. The Easy Fancybox code for YouTube is not rewritten by WP Rocket, even with “All Files” selected in WP Rocket’s CDN settings. So now I can use the CDN with images as well as CSS & Javascript, and the lightbox for videos will still work.

Just wanted to pass this on in case it helps someone else. Thanks!

Tested again and confirmed.

I found a difference in the page source that may help narrow down the cause.

With WP Rocket CDN set to CSS & Javascript only (no images), lines 38-39 look like this and Easy Fancybox runs as expected:

/* YouTube */
jQuery('a[href*="youtu.be/"],area[href*="youtu.be/"],a[href*="youtube.com/"],area[href*="youtube.com/"]').filter(function(){return this.href.match(/\/(?:youtu\.be|watch\?|embed\/)/);}).not('.nolightbox,li.nolightbox>a').addClass('fancybox-youtube');

With WP Rocket CDN set to All Files (including images), lines 38-39 look like this and Easy Fancybox does NOT run as expected:

/* YouTube */
jQuery('a[href*="youtu.be/"],area[href*="youtu.be/"],a[href*="youtube.com/"],area[href*="youtube.com/"]').filter(function(){return this.href.match(https://cdn.besttechnologyinc.com</\/(?:youtu\.be|watch\?|embed\/)/);}).not('.nolightbox,li.nolightbox>a').addClass('fancybox-youtube');

It appears that our CDN URL is getting replaced/inserted in a place where it doesn’t belong.

It would be better, of course, if we could use the All Files option with the CDN instead of just CSS & Javascript. So if this is something you can help with, that would be great. Otherwise we can just keep the WP Rocket CDN setting to CSS & Javascript only.

Hope this helps!

Cheryl Bader

Thank you for your reply.

I tried deactivating “Minify HTML” in WP Rocket but that did not solve the issue.

But when I changed the WP Rocket CDN settings to “reserved for CSS & Javascript” (not images), the issue was resolved. Video and image links now pop up in a lightbox as expected in an incognito browser window.

Thank you for steering me in the right direction to solve this! Much appreciated.

Best regards,
Cheryl Bader

Thank you so much, got it working – yeah! Much appreciated!

Nope, I’m afraid we cannot allow it to be included in the minification again, since that broke the contact form, and generating sales leads via the contact form is primary purpose of the website.

Here is what we came up with as a solution:
In W3 Total Cache, under Minify, add these files to “Never Minify the following JS files”:
wp-content/plugins/easy-fancybox/js/jquery.fancybox.1.3.23.min.js
wp-content/plugins/easy-fancybox/js/jquery.easing.1.4.1.min.js

This resulted in a slight performance hit because the files are no longer combined (concatenated) but it’s slight enough to live with.

So – not clear on the cause of the problem – but we’re going to roll with this solution.

Thank you again for your help.

Thanks for your reply.

We upgraded from version 1.8.9.

Thank you!