bramwaas

released version 2.5.0. with basic support for categories as described earlier.

Exception: 9 Make a toggle (or select) option to display the set of categories on top of an event (in a SMALL HTML line). This is not implemented as a toggle, but a string field where you can fill in the separator. If you leave this field empty the categories set will not be displayed.

Uploaded to the plugins directory as 2.5.0.RC. if you like you can test with this version.

I will perform some regression tests to gain more certainty that the existing functionallity still works properly.

If I don’t encounter any major issues, I will release version 2.5.0 as the stable version in about two weeks

Thank you,

I have read your feed and the additional information. That convinced me that support for categories could be usefull for at least one user and also helps me to find a practically workable solution.

This is what I have in mind now for the implementation:

1. Retrieve the set of categories from the iCal events (when they exist) into my plugin-events as the event-set. Keep in mind that one event can contain 0 or more categories and that a category can contain a space.
2. Make one filter with a comma separated list of categories as the filter-set.
3. Make possible to choose one method to assess the intersection of both sets from a limited list of operators, ANY, ALL, NOTANY, NOTALL (maybe I find better names or symbols later)
4. ANY is true when at least one of the elements of the filter-set is contained in the event set, or in other words, the filter-set intersects the event-set, the intersection contains at least one element. This seems to me the most practical operator.
5. ALL is true when all the elements of the filter-set are contained in the event set, or in other words, the intersection contains the same number of elements as the filter-set. The event-set may contain other elements.
6. NOTANY is true when ANY is NOT true. The intersection is empty.
7. NOTALL is true when ALL is NOT true. The intersection contains less elements then the filter-set.
8. A special case are events without a categories set. As I have described it here the will only appear when the operator is NOTANY or NOTALL. I think of using a null-string (“”) in the filter set to represent events without a categories set. I don’t think this is correct in set theory and it may theoretical possible to define a category as a null string. Nevertheless I think this is te most practical solution to add the events without a category positive to a filter.
9. Make a toggle (or select) option to display the set of categories on top of an event (in a SMALL HTML line)
10. Add the list of categories of an event cleaned as classes (removed spaces etc.) to the html-classes of event.

Once I have realized this, I consider this issue resolved.

Regards

Bram

• This reply was modified 4 weeks, 1 day ago by bramwaas.
• This reply was modified 4 weeks, 1 day ago by bramwaas.

Hi,

thank you for using my plugin.It always make me feel good to see my plugin seamless used in a beautiful website like yours.

I am glad to consider adding support for categories.This are my thoughts about it since I read your issue:

1. It is a small addition in functionality not very difficult to add, but it is a change in the core so an error or other side effects will potentially hit all existing users. So extra attention for testing is needed.
2. why use categories? To achieve (almost) the same goal in google or outlook I use different calendars under one account, if you could do that in the application that creates the iCal feed it would work without an adaptation of my plugin.
3. should I only filter or also display the categories?
4. How will google and outlook export categories in the ical file. How are they showed in their web-calendars. Here I came across a problem. Google does not support categories, Outlook does, but does not share them in the ical file. That makes the added value of the functionality much less and makes it difficult for me to create a realistic test file.

Conclusion so far: I will work on it, if you can send me an ical file (or url if it is public available ) from your feed source ( e.g. to bram at waasdorpsoekhan.nl) and tell me why a solution with more calendars, or different urls for each category does not work for you.

Regards

Bram Waasdorp

Hi Knut,

following the WordPress documentation of add_submenu_page()

“$parent_slugstring required. The slug name for the parent menu (or the file name of a standard WordPress admin page).”

I have changed the first parameter from null in ‘admin.php’ and in my test environment the Deprecation warnings are gone.

I think that is a solution for this issue.

I committed it as Version 2.4.2 to the plugin directory.

Regards Bram

• This reply was modified 6 months, 1 week ago by bramwaas.

Hi Knut,

Thank you for your comment.

At first sight it seems to be this line of code:

add_submenu_page(null, //parent slug …

where the null parameter should be a string.

Maybe replacing null by ” is a solution, but I will come with an update soon.

Regards Bram.

Hi Johan,

It was not difficult to reproduce the issue, even with the default Twenty Twenty-one theme. Apparently my assumption that the keys of the $args array only are filled or changed after initialization is not correct.

In v2.4.1 that I just released, I solved it by defaulting all keys from $args that I use. This should definitively resolve this issue.

Apologies for not testing this sufficiently with ‘WP_DEBUG’ = true.

Kind regards,

Bram

• This reply was modified 6 months, 2 weeks ago by bramwaas.

Hi,

A quick look at the code tells me that that array key should exist and be filled with ‘Simple_iCal_Widget’ when the widget is proper initialized.

It clearly is not.

So a work-around until I have found the reason for the issue and have solved it could be to replace $args[‘classname’] by ‘Simple_iCal_Widget’ in line 170 of file simple-google-icalendar-widget.php ( see error message for complete path). I think this is possible from an administrator screen in WordPress otherwise you could use Filezilla or an other FTP client.

Of course I will come with a solution soon

submitted 2.3.1

Submitted version 2.3.1.

In Advanced option ‘Period limits’ you can now choose for whole day, or time of the day for begin and end limit of the moving window.

This is of cause depending on the local timezone. So I have also provided an option to choose the browsers timezone settings. When you choose ‘Use client timezone settings with REST’ the output is created with a REST call after the window is loaded and then the timezone settings of the browser are used in stead of the wp-installation timezone setting. This affects also the display time of the events.

solved in v 2.3.1.

I have tried to reproduce your issue in my Google Calendar and also added some other characters that may be an issue because I think the issue has something to do with escaping special chars and not correct unescaping them again. I did not see a problem with the comma, but the backslash did change in two backslashes.

So I went back to the ical specification and read that e.g. a comma should be escaped as \, . So your calendar application does it right and my plugin should replace all escaped chars following the description below.

Looking at my code I saw that \, and \; are unescaped, that is why I could not reproduce the issue in Google Calendar. But in longer descriptions the description is divided in smaller parts and when the division is between the \ and the , my plugin does not remove the backslash.

And indeed when I added a long row of commas in my event on Google Calendar one (or more) commas where displayed as backslash comma. So I was able to reproduce it. I think I will do this in the next version 2.3.0. I hope that will solve your issue.

For a work-around you can add an extra space somewhere before the comma in the line where the backslash is added. Thank you for helping me to improve my plugin

Regards Bram

From the specifications: ESCAPED-CHAR = (“\\” / “\;” / “\,” / “\N” / “\n”) ; \\ encodes \, \N or \n encodes newline ; \; encodes ;, \, encodes , The “TEXT” property values may also contain special characters that are used to signify delimiters, such as a COMMA character for lists of values or a SEMICOLON character for structured values. In order to support the inclusion of these special characters in “TEXT” property values, they MUST be escaped with a BACKSLASH character. A BACKSLASH character in a “TEXT” property value MUST be escaped with another BACKSLASH character. A COMMA character in a “TEXT” property value MUST be escaped with a BACKSLASH character. A SEMICOLON character in a “TEXT” property value MUST be escaped with a BACKSLASH character. However, a COLON character in a “TEXT” property value SHALL NOT be escaped with a BACKSLASH character.

In version 2.3.0 I will remove title when it is empty.

I will also remove unsafe/unknown tags from the title so you can restore an empty title line by filling it with <> or any other unknown tag e.g. <empty>

Looks good on your website.

Thanks for sharing this nice solution.

Good luck with your performances.

Regards Bram

• This reply was modified 9 months, 1 week ago by bramwaas.

Hi,

On my system wp_kses is not blocking proper links, but but it depends on how you enter the link in the agenda, whether it is actually offered as a link in the ical file and therefore in the block

First the way that works for me, perhaps not the most obvious way, but reliable:

In the calendar on the web and greate or change an event. In the description editor Click insert link button in the toolbar. You get a popup where you can fill in two fields. In the first I filled in: “Tex for the link” in the second the (example)url of my facebook page: “https://www.facebook.com/my.facebookpage ” after hitting OK button I saw the forlowing in my agenda description editor:

Below I create a working facebook link

Tex for the link

“Tex for the link” is underlined as a link. After saving the event I found the following text in my iCal file related to this event:

DESCRIPTION:Below I create a working facebook link<br><br><a href="https://
 www.facebook.com/my.facebookpage">Tex for the link</a>

After clearing the cache I saw it in my block as:

14:30 Event with facebook link
Below I create a working facebook link

Tex for the link
14:30 – 15:30

“Tex for the link” is underlined and when I click on it “https://www.facebook.com/my.facebookpage ” will be opened.

Other ways that may be more obvious, such as copying the URL directly into the description, seem to work in both Google Calendar App and Web Browser, but usually just export the URL to the ical file as plain text. The block then only shows the text of the URL, no link. Sometimes the URL is promoted to a link when the event is updated, but this is not reliable.

As far as I can see wp_kses does not block the link.

Regards,

Bram

• This reply was modified 10 months ago by bramwaas.
• This reply was modified 10 months ago by bramwaas.
• This reply was modified 10 months ago by bramwaas.