bof1946

To fix the problem with the grid layout in version 3.9.5:

In file include/widgets/testimonial_grid_widget.php line 422 (in function widget), remove wp_kses_post( ) around the call of easy_t_testimonials_grid_shortcode.

Also there’s another function named safely_display_testimonial in include/settings/theme.options.php which has the same bug as Gal Baras’ fix above.

FYI we updated to PHP 8.1 a few days ago, and now BackWpUp is logging some DEPRECATED warnings.However the backup seems to work OK.

Here is the latest log (website URL and database name obfuscated for security):

[INFO] BackWPup 3.10.0; A project of Inpsyde GmbH
[INFO] WordPress 5.8.3 on https://xxxxxxx/
[INFO] Log Level: Normal (translated)
[INFO] BackWPup job: Weekly Backup
[INFO] Logfile is: backwpup_log_3a6116_2022-01-21_13-06-09.html
[INFO] Backup file is: backwpup_P3A777VF01_2022-01-21_13-06-09.zip
[21-Jan-2022 13:06:09] 1. Try to backup database …
[21-Jan-2022 13:06:09] DEPRECATED: Return type of Symfony\Component\OptionsResolver\OptionsResolver::offsetExists($option) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:09] DEPRECATED: Return type of Symfony\Component\OptionsResolver\OptionsResolver::offsetGet($option) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:09] DEPRECATED: Return type of Symfony\Component\OptionsResolver\OptionsResolver::offsetSet($option, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:09] DEPRECATED: Return type of Symfony\Component\OptionsResolver\OptionsResolver::offsetUnset($option) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:09] DEPRECATED: Return type of Symfony\Component\OptionsResolver\OptionsResolver::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:09] DEPRECATED: substr(): Passing null to parameter #1 ($string) of type string is deprecated
[21-Jan-2022 13:06:09] DEPRECATED: substr(): Passing null to parameter #1 ($string) of type string is deprecated
[21-Jan-2022 13:06:09] DEPRECATED: substr(): Passing null to parameter #1 ($string) of type string is deprecated
[21-Jan-2022 13:06:09] Connected to database xxxxxxxxxxx on xxxxxxxxxxx.db.1and1.com:3306
[21-Jan-2022 13:06:09] Added database dump "xxxxxxxxxxx.sql.gz" with 75.43 KB to backup file list
[21-Jan-2022 13:06:09] Database backup done!
[21-Jan-2022 13:06:09] 1. Trying to make a list of folders to back up …
[21-Jan-2022 13:06:33] Added "wp-config.php" to backup file list
[21-Jan-2022 13:06:33] 1205 folders to backup.
[21-Jan-2022 13:06:33] DEPRECATED: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:33] DEPRECATED: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:33] DEPRECATED: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:33] DEPRECATED: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:33] DEPRECATED: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:34] 1. Trying to generate a file with installed plugin names …
[21-Jan-2022 13:06:34] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:34] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:34] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:34] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:34] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:06:34] Added plugin list file "xxxxxxxxx.pluginlist.2022-01-21.txt.gz" with 803.00 B to backup file list.
[21-Jan-2022 13:06:34] 1. Trying to generate a manifest file …
[21-Jan-2022 13:06:35] Added manifest.json file with 3.24 KB to backup file list.
[21-Jan-2022 13:06:35] 1. Trying to create backup archive …
[21-Jan-2022 13:06:35] Compressing files as ZipArchive. Please be patient, this may take a moment.
[21-Jan-2022 13:07:01] DEPRECATED: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:01] DEPRECATED: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:01] DEPRECATED: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:01] DEPRECATED: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:01] DEPRECATED: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:02] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:02] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:02] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:02] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:02] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:30] DEPRECATED: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:30] DEPRECATED: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:30] DEPRECATED: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:30] DEPRECATED: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:30] DEPRECATED: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:31] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:31] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:31] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:31] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:31] DEPRECATED: Return type of Requests_Utility_CaseInsensitiveDictionary::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:52] Backup archive created.
[21-Jan-2022 13:07:52] Archive size is 122.73 MB.
[21-Jan-2022 13:07:52] 7512 Files with 201.46 MB in Archive.
[21-Jan-2022 13:07:52] DEPRECATED: Return type of Requests_Cookie_Jar::offsetExists($key) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:52] DEPRECATED: Return type of Requests_Cookie_Jar::offsetGet($key) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:52] DEPRECATED: Return type of Requests_Cookie_Jar::offsetSet($key, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:52] DEPRECATED: Return type of Requests_Cookie_Jar::offsetUnset($key) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:52] DEPRECATED: Return type of Requests_Cookie_Jar::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
[21-Jan-2022 13:07:52] One backup file deleted
[21-Jan-2022 13:07:52] One old log deleted
[21-Jan-2022 13:07:52] Job done in 103 seconds.

Thanks. I accidentally deactivated NextGen Gallery when I did a bulk deactivate of plugins. When I reactivated it the slideshow link appeared, except it’s now below the thumbnails instead of above them. I reactivated the other plugins one by one and the link is still there OK. I notice that the CSS applied to class slideshowlink is different, so it looks like deactivating and reactivating the plugin has reset something.
“Show slideshow link” is set to Yes in Gallery settings. I looked at the shortcode for the most recent gallery I’ve created and it’s simply [nggallery id="38"]without any other attributes. I can’t find anything about Customize display settings when I edit a gallery, there’s a “Gallery Settings” at the top, but nothing about a slideshow there. However the slideshow link is now visible and the slideshow works so problem solved.
Thanks for your help.

This was so easy I’m embarrassed to confess, but I only had to change the URL of the route and append the data in a query string instead – a one line change – and everything else just worked. For the benefit of any other dimwits like me, WP_REST_Request::get_params returns all parameters, whether they come from a path expression, the query string, or $_POST.

Thanks very much, that’s exactly the sort of inspiration I was hoping for. This is the first time I’ve done anything with the REST api, and I’m still feeling my way reading tutorials and studying the code for other plugins with custom endpoints. It hadn’t occurred to me to use a query string, I can’t remember seeing any examples, but I could have missed their significance. I wasn’t happy about putting the name in the URL for the reasons you point out, but it does seem to work, probably more luck than judgement.

I’ll rewrite my code.

I need the name because anyone could guess a membership number, but the name/number combination is unique.

I’ve noticed that if you select, say, Display Settings under the Easy Testimonials admin menu the correct page is displayed OK, but if you click on the ‘Display’ tab you get “Sorry, you are not allowed to access this page”. This is so obvious that I’m surprised the developers haven’t noticed and fixed it long ago (though of course, it may be a side effect of a recent change to WordPress core).

I’m baffled, because I’ve just upgraded the plugin again and this time it’s worked OK!

For the record the site doesn’t use any sort of caching, unless there’s something set up by the web host that I don’t know about. It’s running PHP 7.3.17 and it’s upgraded to WordPress 5.4.1 overnight.

I can only assume the upgrade didn’t complete properly the first time. Sorry for the false alarm.

John

This plugin seems to be abandoned, which is a shame as I’ve used it successfully on a website for 11 years. However as it does exactly what I need I’ve patched it to fix this warning. If you know of some way to get in touch other than through this forum I’ll be pleased to let you have it. It’s a trivial fix, but I’m not interested in taking over the plugin or supporting my version, so you would use it at your own risk.

Thank you, I can see that would work. I was mainly raising this as a bug report, as it’s debatable whether a query string should be considered part of the URL for redirection purposes. The example of a link from Facebook would mean that you would have to use a wildcard on any such page that someone might link to from FB.

It should probably be guided by the HTTP redirection spec., if it has anything to say about query atrings (I haven’t looked).

Thanks. I thought we had tried that and it still sent an email, but maybe it is another plugin? We’ll investigate.

My test site (with php 7.0) has debug logging enabled, the error I get is
Undefined variable: wp_query in /home/john/public_html/musaclone/wp-content/plugins/theme-my-login/includes/class-theme-my-login.php on line 264
I think the fix is to change $wp_query to $query on this line.

I’ve filed a bug report against WP Survey and Quiz Tool.
I’ve learnt a lot from delving into this!

I now understand the problem. WP Survey and Quiz Tool loads a script file containing jQuery Tools (https://flowplayer.org/tools/). A comment in the file says

* jQuery Tools 1.2.5 - The missing UI library for the Web
 *
 * [tabs, tooltip, overlay, scrollable]

Theme My Login loads the jQuery UI tabs module, and this must conflict with the jQuery Tools version (see stackoverflow.com). Certainly if I rename the script file so it can’t load, the problem with Theme My Login goes away.
I’m not a Javascript expert, so I don’t fully understand how the conflict occurs and I can’t suggest a solution, but if I were jeff I’d want to see if there was any way I could protect my code from a conflict like this.

I’ve narrowed it down in my case to a conflict with the ‘WP Survey and Quiz Tool’ plugin. I’ve noticed that in the failing state, the additional ‘tabs’ classes (ui-tabs, ui-widget etc) are missing from the div #tml-container (and other classes are similarly missing from later elements). I imagine these are set up by the jQuery UI tabs module, which seems to be initialised by code in theme-my-login-admin.js. The script tag for this file is present in the <head> section, though.

I’m guessing that if ui-tabs isn’t initialised it would cause the problems I’m seeing. I have to leave this for the moment, but maybe what I’ve discovered will help.

I can also confirm that there is a problem, and it occurs on two sites which have different combinations of plugins.

I’m going to do a little digging, but I sense it’s something to do with the new style admin menus in 3.3.