bguthro
Forum Replies Created
-
It seemed to, yes.
I reverted the changes I needed to make, in the above comments (s/on/bind/), and everything still seems to be working properly.The problem code in question in the theme was doing the following in includes/theme-scripts.php:
wp_deregister_script('jquery'); wp_register_script('jquery', get_bloginfo('template_url').'/js/jquery-1.4.2.min.js', false, '1.4.2'); wp_enqueue_script('jquery');
I had no idea it was doing that. It was not immediately clear to me that the problem was in a jQuery mismatch.
Again – my apologies.sigh…the theme was explicitly loading an old jQuery, unbeknownst to me.
Sorry for the misplaced accusations.hmm… the WP version installed is 1.8.3 – I guess I’ll have to look around to try to determine why 1.4.2 is being loaded, if that is what you’ve determined.
@jonahcoyote – The version of jQuery I am running is whatever ships stock with WP 3.5 (the latest available.) It seems a bit risky to other functionality to upgrade that.
Plugins to a platform should conform to the restrictions of that platform, and not require additional non-standard configuration.
If you require a particular version of jQuery, you should ship this as part of the packaging, or make it clear to the user that you require a minimum version in order to not break other parts of the WP platform.
@jonahcoyote – I don’t have any errors because, as I mentioned before, I fixed them with the s/on/bind/g fix.
I can’t break the site for the purposes of debugging – but the site in question can be found at https://www.iamers.org
It is running 2.0.11, and it needed the modifications mentioned above in order to not throw javascript errors, and break other things, like menus, and the front page image.
roblagatta, I honestly couldn’t tell you, since I wasn’t the one who upgraded the plugin – I just got the call when it broke.
The last time I fixed it would have been whatever version was available at the time of my original comment, then again a few days ago. The person who upgraded it simply saw in the wp-admin plugins panel, that updates were available, and upgraded.
Sadly, there is no way to roll back an update.
I have advised her to not update this plugin unless I have time to debug and fix issues, since 2 updates have shown it to be an unreliable process prone to breaking the rest of her website.
Yes, I had to patch this version, as well to get it to work again.
All occurrences of “on()” needed to substituted with “bind()”
4 of them were in
the-event-calendar/resources/events.js
1 was in
the-event-calendar/resources/jquery.pjax.jsThese showed up with obvious red error messages in the Chrome Developer console.
roblagatta, is Chrome supported?FYI, I solved this issue by patching jquery.pjax.js
In the first function, change “this.on” to “this.bind”
Patch below for reference:
[ Moderated: Please use pastebin.com and just post the link instead. ]