bengallienne

Hey Randy,

That’s odd, because the form is definitely there. I don’t think I can send a screenshot here but I have one. Can you give it another go please? If necessary, I can probably also set up a site with it broken on that you can have a look at?

Thanks,

Ben

Hi @seanconklin,

We have worked out what this is. If you have more than one form on a page at a time (we have one inline on screen and another available from a link to a popup), the plugin seems to get confused and sometimes styles them both the same way, regardless of their settings. We have worked around it for now with CSS overrides and removal of the popup form from some pages, but ideally the system should be able to cope with multiple items I think?

Thanks,

Ben

Hi Randy,

Apologies for the delay in my reply on this. We worked it out in the end. It seems that the plugin saves the response received from Benchmark in a transient for a while, but is doing so even if the response is an error. Once I cleared out the transients everything went back to normal. It might be worth considering an update to the plugin though to only save successful responses, so this can’t happen in the future?

Thanks,

Ben

Hi Sean,

That’s great, thanks! It works really well and I have updated our staging site. I have another issue to raise now I am afraid, but will do it in a new thread.

Thanks,

Ben

Hi Sean,

This is great, and I can confirm it is working well, thanks so much!

Can you let me know what the next steps would be to get this in to an ‘official’ plugin update please?

Thanks,

Ben

Hi Sean,

This is almost there now, thanks. The only remaining issues I have is including I have is including background colours and images. The particular client in this case wants the email body to have a background colour and image, and the code you have provided to put the content inside the drag and drop editor doesn’t allow me to do that. How should we go about setting that up please? The example I provided above does work for this, but as you rightly pointed out means the content we send ends up not in the drag and drop editor. That doesn’t matter for our use case as the client won’t ever edit it in Benchmark, but it makes sense for your plugin for that to happen. I have some example screenshots of what we end up with in each case that I can send if you want?

Thanks,

Ben

Hi Sean,

Thanks for the super fast response! I’ve had a look at the code and it’s almost exactly what I need. However in this particular situation for this particular client, I need to wrap the title and the content in a div together (to make a box on a coloured background), and also hook in other data from custom fields on the post beneath it. The new $post_html sprintf doesn’t quite allow for that, but I see why you have done it as you have. Can I suggest one final filter pass (after everything) that allows devs to completely adjust things if they need to, like in this case? So just above the line

$body = [ 'Detail' => [ 'TemplateContent' => $TemplateContent ] ];

We add one last filter like this;

$TemplateContent = apply_filters('wpbme_custom_campaign_content', $TemplateContent, $post, $post_title, $post_content);

What do you think? Equally if you are happy to accept a pull request I can put something straight in the repo you posted above?

Thanks again!

Ben