axos1192

Thanks for your response, I definitely learnt something new. I adapted the solution to my needs, I still want to have all rules available because I do add the tables in the frontend myself with direct add to cart options. Your solution feels a little bit snappier than mine.

add_filter('tiered_pricing_table/price/pricing_rule', 'change_pricing_rule_v2', 50, 2);

function change_pricing_rule_v2($pricing_rule, $product_id) {
    if ( $pricing_rule->isPercentage() ) { return $pricing_rule; }
    $product = wc_get_product( $product_id );
    if ( ! $product ) { return $product_id; }

    $pricingRules = $pricing_rule->getRules();
    $salePrice    = $product->get_sale_price('edit');

    if ($salePrice) {
        $pricingRules = array_map(function($rule) use ($salePrice) {
            return min($rule, $salePrice);
        }, $pricingRules);

        $pricing_rule->setRules($pricingRules);
    }

    return $pricing_rule;
}

Thanks! I definitely appreciate your effort!

Hello @bycrik ,

thanks for your fast response. I still have the feeling that the use-case you described is quite an edge-case but agree to disagree ?? Maybe you will implement it optionally in the future or in the premium version of the plugin.

I did actually use your hook but i you have to get the sale state by postmeta query because I tried to get the product object by wc_get_product() from the id but that triggers an infinite loop with the provided hook “tiered_pricing_table/price/pricing_rule”. So not optimal but it works.

Thanks for the fast and, even if the solution is not completely perfect, great support!

hello @doublezed2,

I did as advised and the ticket number is 8836724.

Best Regards,
Martin

@mrclayton, Okay I understand that I have to use the classic checkout then if I want to have google Pay as a normal payment option.

In many parts of the EU the proven visibility of the “general terms and conditions” and the customer agreeing to them is necessary otherwise they are not applicable to the purchase at all. There are some court rulings that state that it is enough to just “show” the block with the “terms and conditions” next to the final “Complete your purchase” Button but that is something only big companies dare to do because proving that the customer has agreed is way easier if the customer has to click a checkbox.
Here?is an article of an it-law company concerning that exact topic. its in German but I think google translate should transport the main message quite well.

What about the compliance issue on the express checkout button in both checkout versions?

Hi @mrclayton,

That’s because the WC Checkout Block is react based and the WooCommerce code is much more opinionated and there are limitations to what can be customized. The checkout block doesn’t support the ability to have the same payment method as an express checkout option and in the payment method section. If that’s a requirement, I would recommend using the checkout shortcode

That’s interesting. I just find it nice to have it as an option to pay as well even though I don’t want to use the express checkout. But that may be preference. Can Google Pay/Apple Pay be available if the Express Checkouts are disabled?

If you have some documentation that highlights that as an issue we’re always interested in improving compliance.

In many parts of the EU the proven visibility of the “general terms and conditions” and the customer agreeing to them is necessary otherwise they are not applicable to the purchase at all. There are some court rulings that state that it is enough to just “show” the block with the “terms and conditions” next to the final “Complete your purchase” Button but that is something only big companies dare to do because proving that the customer has agreed is way easier if the customer has to click a checkbox.
Here is an article of an it-law company concerning that exact topic. its in German but I think google translate should transport the main message quite well.

Hello @doublezed2,

Actually the TOS beeing bypassed is the main legal issue. In many parts of the EU the proven visibility of the “general terms and conditions” and the customer agreeing to them is necessary otherwise they are not applicable to the purchase at all. There are some court rulings that state that it is enough to just “show” the block with the “terms and conditions” next to the final “Complete your purchase” Button but that is something only big companies dare to do because proving that the customer has agreed is way easier if the customer has to click a checkbox.

Neither of those options are actually possible with the Express Checkout right now. So a text block with the “terms and conditions” text inside the express checkout popup would be the least to make them applicable and an optional checkbox would make it provable to be sure even without a big legal team ??

Other required Checkboxes being ignored is still somehow an issue because there are many reasons to have those as well but in my case the “terms and conditions” would be fine.

Hello,

I just came across that topic and I have quite different experiences with the behaviour of the express checkout and the google pay payment option:

In WC Blocks Checkout the Checkboxes of the form which need to be validated seem to be ignored completely when using the Express Checkout on the cart page (Google pay) and the Google Pay method won’t show in the payment options.

In the “standard checkout” the express checkout button automatically checks the TOS and then just fails on a second required checkbox.
The “normal” checkout via google pay just waits for all required checkboxes like it should be.

I understand, that “automatically” checking the TOS reduces friction but in European countries that’s definitely not the way to do it.

Thanks, that looks great and helps a lot! ??
(I hope you will implement it in the next release ?? Otherwise the changes would be gone after a plugin upgrade)

Awesome support anyways!

The Product names in that case are the same for english and german. So I can’t distinguish them :/ But sadly seems to be an edge case. Still it would nice to see that somehow (en or de) overlay

When I tried (and I have to say i don’t have wpml auto id enabled). I saw all products duplicated (english and german). I added then 4 products (2 products in german and english) to the popup and afterwards I was only able to see the german products on the german site and the english ones on the english site. Which is fine so far but it would be great if it would be somehow visible which wpml language the products do have while selecting them.

i am using wpml. I meant the product selection in the product. Lock of the popup builder.

I mean, it does have Masonry in its name. which is way easier with a column approach then an row approach.

I assume it had to do with pagecaching and a nginx restart. You are right. I enabled all options again and it still worked fine!
I think that passster won’t be usable for global access in comination with nginx pagecaching anyways, because it will just always save the visible pages as soon as someone was able to visit it.
Why don’t you suggest the AJAX Version for complete sites?

Best Regards,
Martin

Hello, so I just found out “what” the issue was. Passster needs to execute php files in the wp-uploads folder, which was deactivated on my site for security reasons. Is there any way to work around that? I would feel more comfortable if I could activate that security measure again.

Best Regards,
Martin

Actually it didn’t work at first glance but after some debugging, i figured out a way that was working for me with the mu-plugin.

I will post the “complete” “cmplz_wp_google_map_pro_script” function here. Maybe you can double check it on your end and if it works add it to your integrations ??

function cmplz_wp_google_map_pro_script( $tags ) {
    $tags[] = array(
        'name' => 'google-maps',
        'category' => 'marketing',
        'placeholder' => 'google-maps',
        'urls' => array(
            'maps.google.com',
            'wp-google-map-gold/assets/js/frontend.min.js',
            'wp-google-map-gold/assets/js/vendor',
            'var map',
            'maps.js',
        ),
        'enable_placeholder' => 1,
        'placeholder_class' => 'wpgmp_map',
        'enable_dependency' => '1',
        'dependency' => [
            //'wait-for-this-script' => 'script-that-should-wait'
            'maps.google.com' => 'wp-google-map-gold/assets/js/frontend.min.js',
            'wp-google-map-gold/assets/js/frontend.min.js' => 'wp-google-map-gold/assets/js/vendor',
            'wp-google-map-gold/assets/js/vendor' => 'var map',
        ],
    );
    return $tags;
}

Best Regards,
Martin