Forum Replies Created

Viewing 9 replies - 1 through 9 (of 9 total)
  • Thread Starter Al

    (@asierrajr)

    Thank you for the update.

    I have tested on my local install upgrading from version 4.7.2 to 4.8.2. I see the block recovery button at the top of the editor and within the block editors. For single block accordions, clicking it once works without issues. For multiple accordions, I did have to click the Recover Accordion Blocks more than once for it to work throughout the multiple accordion blocks. I have simple accordions to test with so I am going to setup the new version on our sandbox environment and have content editors on my team test this as well who manage more complex accordions. If any issues arise, I can report them to you.

    Thanks again

    Thread Starter Al

    (@asierrajr)

    Thanks for the update.

    We will wait for your next release and test thoroughly on our sandbox environment.

    Thread Starter Al

    (@asierrajr)

    Hi

    Just an update, I just met with our content editor and the accordion block breaking without upgrading the plugin was due to setting the styles for the border to zero. If you clicked on the text box and hit backspace, it borked the accordion. I replicated the issue on my dev environment but upgrading the plugin to 4.8.1 and testing again does not break it. You can disregard this portion of the issue.
    Thanks

    Thread Starter Al

    (@asierrajr)

    Hi

    Thanks for the feedback. The block recovery is erratic, clicking on it either preserves the accordion contents or deletes the accordion contents. Also, we have multiple accordion sets within a single post, clicking on the first block recovery will sometimes delete the others.

    Is there something I can do manually via the code editor for now that i can modify manually instead of relying on the block recovery?

    I did ran a test where creating an accordion in version 4.8.0 and upgrading to 4.8.1 had no issues as you stated. Downgrading from 4.8.1 back to 4.7.2, the accordions created after the patch breaks in the downgraded version. So you might be able to duplicate the issue

    Let me know if there is anything manually I can do for now and I can communicate with our content editors about your single block recovery feature.

    Also, is there an explanation as to why the block recovery would come up without performing any upgrades, like I mentioned previously, the content editor was adjusting some style settings initially.

    Thanks

    • This reply was modified 1 month, 1 week ago by Al.
    Thread Starter Al

    (@asierrajr)

    Thanks for the response and working this issue out together.
    Fix was committed.

    Thread Starter Al

    (@asierrajr)

    Yes it does.

    If you have gtranslate enabled and let say you have a url with the following:
    domain.com/hello-world/?category_id=1

    On first hit, the plugin will cache the contents of domain.com/hello-world/?category_id=1 in ../cache/domain.com/all/hello-world/index.html

    On second hit, if you go to let say domain.com/hello-world/?category_id=2, it will continue to load the contents from ../cache/domain.com/all/hello-world/index.html ( which is not correct since it’s the cached content of domain.com/hello-world/?category_id=1 )

    I reviewed the code snippet I mentioned above in your plugin, REDIRECT_URL will only contain hello-world and the code snippet ignores the query string parameter which is stored in REDIRECT_QUERY_STRING.

    Thread Starter Al

    (@asierrajr)

    Any Updates on this bug?

    Thread Starter Al

    (@asierrajr)

    Thanks for the quick response and fix.
    Tested 1.9.6 and it works now.

    Thread Starter Al

    (@asierrajr)

    Forgot to mention.

    I am using WordPress 5.3 and plugin version 1.9.5 ( I also tried on version 1.9 )

Viewing 9 replies - 1 through 9 (of 9 total)