asha23
Forum Replies Created
-
Found a fix for this – Thanks
I fixed it by doing the following – Replace line 110
$cond = $conditions[$if_conditions[$index]]['condition']; if($cond): $singleCondition .= call_user_func_array($cond, $params) ? $bit1 : $bit2; endif;One of the conditions was returning NULL, so this was breaking the call_user_func_array()
You’re welcome ??
I have exactly the same issue – Latest WordPress version – PHP 7.3
Forum: Localhost Installs
In reply to: PHP PROBLEM…Just swap continue for break, everywhere you can find it.
Forum: Reviews
In reply to: [Media Cleaner: Clean your WordPress!] Horrible pluginIt doesn’t actually work though.
It can’t seem to figure out ACF Flexible Content fields. It deletes anything it can’t find.
It’s like hitting your website with a massive hammer.
Plus the developer (if you can call him that, there are Headers already sent errors all over the shop) admits he’s trying to do an impossible thing.
It’s not impossible. It just takes a bit more skill than you have to pull off.
Rewrite it. Do it properly.
The problem is, this puts a script above the <head> of the webpage.
It will do this, because in the plugin it just echoes out a load of code.
- This reply was modified 6 years, 7 months ago by asha23.
There is a stylesheet just plonked in there as well
The hack starts on line 146 of class-sassy-social-share-public.php
Please fix this plugin and enqueue this inline script properly.
Here’s the code
<script type="text/javascript">function heateorSssLoadEvent(e) {var t=window.onload;if (typeof window.onload!="function") {window.onload=e}else{window.onload=function() {t();e()}}}; var heateorSssSharingAjaxUrl = 'https://azanti.local/wp/wp-admin/admin-ajax.php', heateorSssCloseIconPath = 'https://azanti.local/content/plugins/sassy-social-share/public/../images/close.png', heateorSssPluginIconPath = 'https://azanti.local/content/plugins/sassy-social-share/public/../images/logo.png', heateorSssHorizontalSharingCountEnable = 0, heateorSssVerticalSharingCountEnable = 0, heateorSssSharingOffset = -10; var heateorSssMobileStickySharingEnabled = 0;var heateorSssCopyLinkMessage = "Link copied.";var heateorSssUrlCountFetched = [], heateorSssSharesText = 'Shares', heateorSssShareText = 'Share';function heateorSssPopup(e) {window.open(e,"popUpWindow","height=400,width=600,left=400,top=100,resizable,scrollbars,toolbar=0,personalbar=0,menubar=no,location=no,directories=no,status")}</script> <style type="text/css"> .heateor_sss_horizontal_sharing .heateorSssSharing{ color: #fff; border-width: 0px; border-style: solid; border-color: transparent; } .heateor_sss_horizontal_sharing .heateorSssTCBackground{ color:#666; } .heateor_sss_horizontal_sharing .heateorSssSharing:hover{ border-color: transparent; } .heateor_sss_vertical_sharing .heateorSssSharing{ color: #fff; border-width: 0px; border-style: solid; border-color: transparent; } .heateor_sss_vertical_sharing .heateorSssTCBackground{ color:#666; } .heateor_sss_vertical_sharing .heateorSssSharing:hover{ border-color: transparent; } @media screen and (max-width:783px) {.heateor_sss_vertical_sharing{display:none!important}} </style>- This reply was modified 6 years, 7 months ago by asha23.
Have searched through the plugin. This looks like an injection as I can’t find references to it anywhere in the plugin itself.
What is going on with this???
Scripts should not be loaded outside of the head especially not before my doctype declaration.
It’s a hack.
So give this as an option when you uninstall the plugin.
Usually if someone deletes a plugin they don’t want the data attached to the plugin to be kept.
It shouldn’t always be a constant battle to stop WordPress becoming bloated due to lazy plugin garbage collection (or lack of it)
- This reply was modified 6 years, 9 months ago by asha23.
So give the option when people uninstall (Keep data or not) – Too many WP plugins litter the database. The good ones clean up after themselves nicely.
Leaving user types behind is messy.
There is also this error
Notice: get_screen_icon is deprecated since version 3.8.0 with no alternative available.
Caused by this plugin and none other as I have switched it off.
Running PHP7
Yep. It’s shockingly bad. Left garbage all over my database.
Annoyed.