Aikar

I see there is a github PR on this already here: https://github.com/Yoast/wordpress-seo/pull/3807

and never mind on validation, appears it triggered that when doing a direct input test vs url test. Guess the validator didnt detect stuff correctly.

Instead of forking, why not work to ensure the bugs you are having are fixed?

For content writers, the new snippet box is pretty nice so they can visually see if their copy fits in correctly.

The real time is also a huge benefit. It’s an admin panel, what does weight matter? For writers, to be able to see the plugins input without saving a draft is another huge plus.

If your system/browser is too slow to handle this analysis, maybe the solution to the problem is to fix that instead of keeping to an old version.

I dont believe yoast has anything to do with Article markup at this time, as I just had to add it to my theme myself.

Look at your theme or the other SEO plugin for that.

But ultimately, the new AMP article guidelines is stricter, you need an image and publisher, and the image cant be a direct url anymore. It has to be an image with width and height included.

see for example how I marked it up: https://developers.google.com/structured-data/testing-tool?url=https%253A%252F%252Fwww.icontact.com%252Fblog

(Click on objects on right to highlight it on left since our HTML is minified)

I came up with a solution that fixes it without modifying the plugins files, add this to your theme functions.php

/**
 * Hooks into Custom Permalinks to fix default
 */
function fix_custom_permalink_get_sample_permalink_html($html, $id, $new_title, $new_slug) {
	$permalink = get_post_meta( $id, 'custom_permalink', true );

	if (!$permalink && !empty($new_title)) {
		$permalink = get_sample_permalink($id, $new_title, $new_slug)[1];
		$post = get_post($id);
		if ($post->post_type) {
			$config = get_post_type_object($post->post_type);
			if (isset($config->rewrite) && !empty($config->rewrite['slug'])) {
				$slug = $config->rewrite['slug'];
			} else {
				$slug = $post->post_type;
			}
			$permalink = $slug . '/' . $permalink;
		}
		add_post_meta($id, 'custom_permalink', $permalink );
	}
	return call_user_func_array('custom_permalink_get_sample_permalink_html', func_get_args());
}
add_action('init', function () {
	remove_filter( 'get_sample_permalink_html', 'custom_permalink_get_sample_permalink_html', 'edit_files', 4 );
	add_filter( 'get_sample_permalink_html', 'fix_custom_permalink_get_sample_permalink_html', 'edit_files', 4 );
});

https://github.com/Yoast/wordpress-seo/issues/2303#issuecomment-95215843

Responded there.

This should be a 1 minute task with 0 chance of breaking things (unless you’re doing something really hacky)

I don’t want it outside of root lol, plus it wouldnt change the problem, as the htaccess see’s the openid directory and accesses it instead of sending it to the index.php, so unless all urls went to /wp/blah, problem would still exists.

Making the modification above and simply making it always pipe through index.php fixes the problem.

This shouldn’t matter considering this isn’t something search engines will be hitting (I don’t know of any search engines that will be logging in with openid’s into sites…), and the redirects are fast so you don’t even notice the urls including index.php nor is it something you would bookmark… so it really doesn’t hurt anything to not use friendly urls for this stuff to maximize compatibility with everyone’s site.

I fixed my problem, the plugins code requires that an openid folder not exists to rely on Friendly URLs, so a simple comment out of the check and always use /index.php/openid/consumer fixed the issue.

Plugin author: you should prolly remove that officially and always go through index.php to avoid this problem in future. By me having an openid folder broke the login procedure.

common.php line 860

if ($wp_rewrite->using_permalinks()) {
		//if ($wp_rewrite->using_index_permalinks()) {
			$url .= 'index.php/';
		//}

I’m having issues… I disabled the provider so I can use my own local provider and manually put the <link rel’s in, but now the XRDS is returning the consumer urls as /openid/consumer – which that folder just has my few files for my provider (phpMyID) and is not going to the /wp-content/plugins/openid/ folder.

How can I fix this?