Mike Doherty
Forum Replies Created
-
Forum: Plugins
In reply to: [Vanilla PDF Embed] Email to pdfYou just need to use the
[pdf]
shorttag to embed the PDF. I’ve never used post-by-email, so I can’t help you with that part.Forum: Plugins
In reply to: [Vanilla PDF Embed] Text Field in PDF with link to siteOK, I understand the problem now. This seems to be an issue with the PDF plugin and/or web browser. There’s nothing my plugin can do to fix it. Sorry.
Forum: Plugins
In reply to: [Vanilla PDF Embed] Text Field in PDF with link to siteIt shouldn’t matter whether the PDF is a fillable form or not, it should still be embedded properly in the webpage.
But I’m not sure I understand your question. Can you explain clearly what you’re trying to do, what you expect to happen, and what actually happens?
Forum: Plugins
In reply to: [Vanilla PDF Embed] Download the PDF fileIt doesn’t look like anything the plugin is doing is wrong.
Did you test with the same browser both times? Embedding is dependent on browser support for PDF in
<object>
tags.Forum: Plugins
In reply to: [Vanilla PDF Embed] offset 0 not found — $attachmentWhy don’t we move this conversation to github? You can open issues or pull requests as you see fit there — https://github.com/doherty/WP-vanilla-pdf-embed
Forum: Plugins
In reply to: [Vanilla PDF Embed] offset 0 not found — $attachmentAfter a bit of thought, it seems like the only way this can happen is if there was an error executing the query, or if the row in question has no ID. Can you check if either of those is the case?
Forum: Plugins
In reply to: [Vanilla PDF Embed] offset 0 not found — $attachmentThanks for the report. I’ll include this change in the next version.
Forum: Plugins
In reply to: [Vanilla PDF Embed] It Works! But only on pc- NOT on mobileThis is not a bug in the plugin. The browser doesn’t support PDF embedding.
Forum: Plugins
In reply to: [Vanilla PDF Embed] Firefox pdf issuesOkay, I see what you mean! It opens the link you click *inside the embed frame*.
Unfortunately, I don’t think there’s anything I can do to fix this in the WordPress plugin, it looks like a problem with the PDF plugin and/or Firefox.
I’ve opened a bug for Firefox – https://bugzilla.mozilla.org/show_bug.cgi?id=976541
Forum: Plugins
In reply to: [Vanilla PDF Embed] Firefox pdf issuesIs this site live so I can experiment with it myself?
Forum: Plugins
In reply to: [Vanilla PDF Embed] Firefox pdf issuesWhat is the URL for the link in the PDF that you clicked on?
Forum: Plugins
In reply to: [Vanilla PDF Embed] False positive on jpgs in galleryIf you do
[pdf]https://not a PDF and hosted on some other domain[/pdf]
then we assume you know what you’re doing, and embed it as a PDF… But I think you’re talking about something different.Forum: Plugins
In reply to: [Vanilla PDF Embed] False positive on jpgs in galleryWhat “gallery” are you talking about? If you’re using a plugin, I’ll need to test with the same one as you.
Forum: Plugins
In reply to: [Vanilla PDF Embed] False positive on jpgs in galleryThat seems like it shouldn’t be necessary. A couple lines up, we check for
post_mime_type
beingapplication/pdf
. I’ll do some testing and get back to you.Forum: Plugins
In reply to: [Vanilla PDF Embed] Download the PDF file.Sounds like you’ve done everything right. Can you tell me what browser you’re using? Does it support embedding PDFs – does https://pdfobject.com/markup/examples/sized-element.html work, for example?
If so, can you show me the generated HTML? Press CTRL-U, to see the HTML, and then use CTRL-F to search for the URL you embedded. Take everything from
<object ...>
to</object>
and paste it here. Or just put the whole document on a site like https://p.defau.lt