1benk1
Forum Replies Created
-
Forum: Plugins
In reply to: [Web Stories] Feature plans to use YouTube videos?Thank you for the explanation!
Hello again,
there is a very common way to modify the meta informations for robots from WordPress, this is the hook wp_robots -> best practiceUsing the hook wp_head and just write
<meta name="robots" content="...">
to the<head>
is worst practice, as you will have duplicate and misleading robots information in the HTML.If you take a look into the method
um_profile_dynamic_meta_desc
, there unfortunately the last variant is implemented.Best regards,
BenForum: Plugins
In reply to: [Redux Framework] Critical error after updateThere is still an error in latest version 4.3.24:
An error of type E_ERROR was caused in line 239 of the file /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/extensions/custom_fonts/class-redux-extension-custom-fonts.php. Error message: Uncaught Error: Call to a member function dirlist() on bool in /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/extensions/custom_fonts/class-redux-extension-custom-fonts.php:239
Stack trace:0 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/extensions/custom_fonts/class-redux-extension-custom-fonts.php(103): Redux_Extension_Custom_Fonts->get_fonts()
1 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/classes/class-redux-api.php(250): Redux_Extension_Custom_Fonts->__construct()
2 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/classes/class-redux-api.php(1611): Redux::load_extensions()
3 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/classes/class-redux-extensions.php(118): Redux::set_extensions()
4 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/classes/class-redux-extensions.php(28): Redux_Extensions->load()
3 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/classes/class-redux-extensions.php(118): Redux::set_extensions()
4 /home/www/mywebsite.com/htdocs/wp-content/plugins/redux-framework/redux-core/inc/classes/class-redux-extensions.php(28): Redux_Extensions->load()
5 /home/www/muneda
(with PHP 7.4)
- This reply was modified 1 year, 10 months ago by 1benk1.
With 3.4.10 everthings works fine.
The critical error comes with current version 3.4.9, because you have a wrong comma within /wp-content/plugins/simple-jwt-login/routes/api.php on line 157:
$wordPressData->triggerAction( \SimpleJWTLogin\Modules\SimpleJWTLoginHooks::HOOK_BEFORE_ENDPOINT, $route['method'], $route['name'], $request, );
(after
$request
).Forum: Plugins
In reply to: [Web Stories] Feature: new block type to support categoriesHello again, here is a pull request to this feature:
https://github.com/GoogleForCreators/web-stories-wp/pull/12322Hi Benny,
the bug seems fixed with this beta version.
Many thanks for this really quick fix.Best regards,
BenHi Benny,
I think I have found the problem…We use following code within the child theme:
add_action( 'after_setup_theme', function() { remove_theme_support( 'core-block-patterns' ); } );
This code snippet is recommended to disable the wordpress default pattern.
(see for example https://wpblockz.com/tutorial/remove-default-block-patterns-from-wordpress/)2.0.4 has no problem with this but version 2.0.5 and later crashed in case of
remove_theme_support( 'core-block-patterns' );
Best regards,
BenForum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Slow query after update to 1.0.37Hello again,
I was 1 week in vacation, so sorry for the late answer…
Today morning we have updated to version 1.0.39 and currently everything seems fine (after ~5 hours).Best regards,
BenForum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Slow query after update to 1.0.37This sounds great! Thank you!
For all others out there with a realy big site (> 50k posts and millions of postmeta-data), the version 1.0.35 seems stable.
After downgrade to this version the site rans smooth and the DB-load is nearly the half of the DB-load we checked out with 1.0.37 or 1.0.38.
(The version 1.0.36 was never live on our site, but in other threads I have read that this version make troube as well.)
Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Slow query after update to 1.0.37Version 1.0.38 has the same problem.
Forum: Plugins
In reply to: [AMP for WP - Accelerated Mobile Pages] Slow query after update to 1.0.37Hello again,
After some analysis I can tell you what is the problem with these queries…
This is the original query from my first comment above:
SELECT wp_posts.ID FROM wp_posts LEFT JOIN wp_term_relationships ON ( wp_posts.ID = wp_term_relationships.object_id ) INNER JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id ) WHERE 1=1 AND wp_posts.ID NOT IN ( 301840 ) AND ( wp_term_relationships.term_taxonomy_id IN ( 6,394 ) ) AND ( wp_postmeta.meta_value != 'hide-amp' ) AND wp_posts.post_password = '' AND wp_posts.post_type = 'post' AND ( (wp_posts.post_status = 'publish') ) GROUP BY wp_posts.ID ORDER BY wp_posts.ID DESC LIMIT 0, 3
-> query execution time ~3 seconds
This is the same query with a pre-selection to the postmeta-key “ampforwp-amp-on-off”:
SELECT wp_posts.ID FROM wp_posts LEFT JOIN wp_term_relationships ON ( wp_posts.ID = wp_term_relationships.object_id ) INNER JOIN wp_postmeta ON ( wp_posts.ID = wp_postmeta.post_id ) WHERE 1=1 AND wp_posts.ID NOT IN ( 301840 ) AND ( wp_term_relationships.term_taxonomy_id IN ( 6,394 ) ) AND ( wp_postmeta.meta_key = 'ampforwp-amp-on-off' ) AND ( wp_postmeta.meta_value != 'hide-amp' ) AND wp_posts.post_password = '' AND wp_posts.post_type = 'post' AND ( (wp_posts.post_status = 'publish') ) GROUP BY wp_posts.ID ORDER BY wp_posts.ID DESC LIMIT 0, 3
-> query execution time ~0,15 seconds
You have definitely to pre-select the millions auf postmeta-data (on big sites) to some thousand postmeta-data with the key “ampforwp-amp-on-off”.
Best regards,
BenForum: Plugins
In reply to: [My WP Translate] PHP warning in error_log_php fileThis warning occurs with PHP 7.3 and should be fixed, because with PHP 8.x this will be a compile error!
See also:
https://www.php.net/manual/en/control-structures.continue.phpHello,
We don’t want to have the blogname within our title on AMP.In the non-amp version the method
title
within/wp-content/plugins/wordpress-seo/frontend/class-frontend.php
makes a very good job and generates a SEO title.Unfortunaly the filter of Yoast has only a priority of 15 and will be overwriten now by your filter (with priority 20) in the amp-version.
Best regards,
BenForum: Developing with WordPress
In reply to: How to override a method of editor.js within custom block?I solved the problem and change the onChange within <URLInput>:
<URLInput value={ url } onChange={ ( value, post ) => { setAttributes( { url: value } ); if ( post && post.hasOwnProperty( 'id' ) ) { setAttributes( { id: post.id } ); } } } />
Because in case of select a link, the second argument is defined and containts the id ??