Your admin CSS overwrites default components

  • Resolved Timo

    (@worschtebrot)


    7 years, 4 months ago

    Hi,
    after installing your plugin, I realized that some WP dashicons looked different in my WP admin section, even on pages which have nothing to do with your plugin. This is because you change the layout of some dashicons to your needs, but you do not care about loading your CSS just on your plugin’s pages. Could you please change that.

    Thanks

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Ahmed Kaludi

    (@ahmedkaludi)

    Hi @worschtebrot

    That’s extremely strange. I apologize for that inconvenience.

    We do not really modify the Dashicons, but maybe it could be due to some conflict with some CSS.

    Can you please help me find it out? Where do you see it? Can you share the screenshot?

    YES! We actually care about loading our CSS only on our plugin’s page, I will create a ticket about this and make sure that the CSS is only loading on the pages where it’s necessary. I have created a ticket for this: https://github.com/ahmedkaludi/accelerated-mobile-pages/issues/1441 – We will make sure that it’s fixed in the upcoming updates.

    Regards

    Thread Starter Timo

    (@worschtebrot)

    This is still in your CSS code which gets loaded on the admin pages of my plugin:

    .dashicons-warning, .dashicons-yes{
            font-family: dashicons;
            font-style: normal;
            position: relative;
            top: 1px;
            font-size: 32px;
            margin-right: 18px;
        }
        .dashicons-yes{
            margin-right: 25px;
        }
        .dashicons-yes:before {
            content: "\f147";
            background: #388e3c;
            color: #fff;
            border-radius: 40px;
            padding-right: 3px;
            padding-top: 1px;
        }

    This changes the dashicons for your custom demand but also on other pages. You should be aware of this when you change the layout of standard components.

    So I would suggest you add a custom CSS class to the dashicons where you use them and adjust the CSS code to only address your custom classes, like:

    <span class="dashicons dashicons-amp dashicons-yes"></span>

    And then:

    .dashicons-amp.dashicons-yes { ...

    I hope this can be made with the next update.

    Plugin Author Mohammed Kaludi

    (@mohammed_kaludi)

    Yes! We are definitely going to add this in the upcoming updates. Thank you for letting me know in details!
    We are finishing a big update, as soon as this gets finished, we will start pushing bug updates faster

    Thread Starter Timo

    (@worschtebrot)

    Obviously this fix has not been part of update 0.9.72 ;-(

    Plugin Author Mohammed Kaludi

    (@mohammed_kaludi)

    I’m extremely sorry, we were restructuring our development cycle. I have already assigned it to a milestone, that will be fixed as soon as possible. You can track that ticket as well.

    Plugin Author Mohammed Kaludi

    (@mohammed_kaludi)

    @hedayetullah

    I’m having problem understanding your question. Can you please elaborate it for me? I will try my best to help you out

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Your admin CSS overwrites default components’ is closed to new replies.

Tags