Wrong image dimensions in Slideshow

@henri2pw – How are you inserting the slideshow into the popup?

– Cais.

Hello,
Using the latest version of the plugin named ‘PopUp Maker’

and on a normal page (without the popup), the slideshow appears right, like that : https://immobilierdecorse.com/rtest/
…

@henri2pw – Given NextGEN Gallery only appears to be breaking when used by another plugin you might want to work with the other author to see if they can correct / modify their code appropriately to have NextGEN Gallery work within it.

Thanks!

– Cais.

@henri2pw Took a look myself (<– Popup Maker author), and the popup doesn’t seem to be there, I am assuming it has been disabled? Would be glad to chime in here and help get this working correctly.

Assuming you set the size of the popup to be responsive and chose one of the widths, this will set the images inside should be set to max-width of 100% or the width of the popup.

A live example of how its breaking would be greatly helpful.

PS we don’t do any content manipulation so it will boil down to one of two possible causes.

CSS issue possibly due to our responsive image rules, or JS not firing for the gallery inside the popup due to it being loaded in the footer after scripts. This is the case with things like gravity forms where they use has_shortcode to detect their forms and load scripts when needed. Problem is we load popups in the footer and by that point their code isn’t looking for shortcodes anymore.

We combat this by preloading the popups in the header so that their content can be checked for forms etc, but the detection isn’t automatic. We call the GForms function to enqueue scripts when a form is detected.

Those are the only 2 possible causes here.

@danieliser – it looks as though the example posted at https://immobilierdecorse.com/ is back up.

Thanks,

Drew

@photocrati any ideas why they would be showing thumbnails instead of the full size image? Is it part of the shortcode?

The image in the popup is being served as 200×100 not scaled to that size.

The image link contains the /preview/ prefix in its url.

As I said we don’t process the content other than through the basic filters applied to the_content. That said we don’t use the_content as it caused issues with popup content being removed or filtered inappropriately when used with some plugins such as bbPress which removes content such as shortcodes.

Is there a filter you are applying to the_content that we need to mirror? Your plugin is more than popular enough for me to include some fixes inside ours if there is something extra needed.

I do not know.. What I can say is that it worked when I was using the previous version of Popup Maker. This problem appeared when I updated the plugin..

Maybe I should re-install Popup maker, version 1.1.8
Whqt do you think ?

Thanks anyway ??
H

Ok then it is most definitely a filter issue. We had to remove usage of the_content filters and apply them via the_popup_content now as to many plugins such as bbPress, jetPack etc were adding/removing content from the popups.

We likely just need to add the same filters Nextgen is using on the_content to the_popup_content and all will be good.

v1.1.9s main changeset was removal of those filters.

ok ??

@danieliser – Because of the core issue (#17817) we have had to do a lot of work to get around the issues with the_content filter hook.

It may be best for you to send us a Bug Report (https://nextgen-gallery.com/report-bug/) so we can open up a conversation and get you in touch directly with our developers to help get this sorted out.

As it is, I’ll add this topic to their review list as well.

@henri2pw – I’m not really clear in this at the moment, are you up and running correctly again?

Thanks!

– Cais.

@photocrati – How do you filter the_content? If you have a list of filters you add to the content, if you can post them here I can craft a solution for him.

Basically I removed all usage of the_content and replaced it with a custom filter the_popup_content. So we just need to apply your filter functions to the_popup_content in the same way you apply them to the_content and that should resolve that issue. I will submit issue with your dev team and see if we can get it resolved.

@danieliser – As I wrote, we will have to have one of our developers weigh in on this. You are more than welcome to share the solution(s) that may come from that exchange but I believe this will be more involved than what you are describing as is.

Thanks!

– Cais.

PS: You could look at defining this constant NGG_DISABLE_FILTER_THE_CONTENT but that can create conflicts elsewhere.

@photocrati I submitted the issue via your bug report form and will work with them to find a permanent solution. Thanks for all of your help.