Wrong days in monthly timetable and Quick Update – caused by 2019 dates in CSV?

  • Resolved HashimA

    (@kaosindustries)


    4 years, 2 months ago

    Salaam Mustafiz.

    I’ve come across a pretty serious bug. In both Quick Update and the monthly timetable, the dates are right but the days are wrong. So even though today is currently showing as the 9th of September it is showing as a Monday even though it is currently a Wednesday.

    Looking in 2020 prayer times CSV confirms that it’s using 2019 dates, and checking 9th September 2019 in a calendar shows that that date was indeed a Monday, so I think this “bug” may be related to the CSV showing 2019 dates, although you only you could tell for sure.

    Is there any way to fix this?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter HashimA

    (@kaosindustries)

    I managed to fix this by looking at the code for the “Day” column in MonthlyTimetablePrinter.php and seeing that it was getting the day by computing the d_date column in the CSV.

    I’m not sure why the prayer-time-2020.csv file still has 2019 dates, but the steps to solve this are:

    – Open the CSV in Excel and do a search and replace (Ctrl+F), searching for “2019” and replacing with “2020”

    – Select and convert all of the dates to an American format that the plugin will accept (Select all of the date cells, Ctrl+1, and select YYYY-MM-DD or a similar format)

    – Save the CSV, click Yes when Excel asks to save it in non-workbook format, then exit and click No when Excel asks if you want to save it again

    – Re-upload the CSV

    Plugin Author mmrs151

    (@mmrs151)

    Assalamualaikum bro,

    Jazakallah khair for this.

    Thread Starter HashimA

    (@kaosindustries)

    Ws, and no problem at all. Was it intended for the 2020-prayer-time.csv file to have 2019 dates or was this a mistake?

    • This reply was modified 4 years, 2 months ago by HashimA.
    Plugin Author mmrs151

    (@mmrs151)

    it is definitely a mistake.
    I released an update, if possible if you deactivate and reactivate, it will fix the issue I hope.

    Mustafiz.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Wrong days in monthly timetable and Quick Update – caused by 2019 dates in CSV?’ is closed to new replies.