wp-Typography and Divi

Hi @frank-j! I’d be glad to help, but I still don’t have enough information on Divi. Unfortunately, their developer documentation is pretty sparse and as it is a closed-source product, I can’t just look at the code (or test things).

Hi Peter,

thanks for your reply.

Divi Development has the problem on its list — but of course there’s no statement when they will look at it. So far Divi Support claims that it is a Plugin problem though.

While chatting with Dvi Support I got this statement:

“They should change their code so they will not look only for the_content function but the entire code in the page.”

Maybe this can help?

Cheers, Frank

PS. I am just starting with Divi and encountered the problem in this project:

https://occupy-occupy.de

The left side of the starting page (one column) is generated by a Post/Page. Hyphenation works here as expected. The right side of the starting page (two columns) is content generated by the Divi Theme Builder — as you can see hyphenation does not work in this area.

Hi @frank-j, it is possible to process the entire page output with PHP output buffering, but if there are any constructs that trip up the HTML parser (either due to the document not being well-formed or because the parser has a bug), the site can break. This is much less likely when using doing it selectively via filter hooks (also this is much closer to the “WordPress way” of doing things).

A full-page mode is something I’ve been thinking about for some time, but as there is no standardized API (i.e. no existing filter hook), there’s a lot of breakage risk, so I’d have to support both the various filters and the full-page mode for the foreseeable future. I don’t know if I want to do that.

To be honest, a dismissive answer like the one by Divi support is not something that makes me more willing to donate hours of my time for improving compatibility with a commercial closed-source theme. I’m not blaming you as the messenger, but they have all the necessary information (their own code and mine), but somehow expect me to fix things.

PS: It would help if you could try out the snippets in my initial comment in the other thread – that would be the basis for a full-page mode.

Hi Peter,

I fully understand your point regarding your motivation. I felt the same when I read Elegant Theme’s statement.

Besides that I tried the snippet. Result: no hyphenation in the parts generated by Divi’s Theme Builder.

Cheers, Frank

Can you try to add error_log() calls to see if the functions are called at all? If not, it would appear that those action hooks don’t fire when using Divi.

Hi @frank-j, have you been able to check whether the functions get called at all?

Hi Pepe,

I somehow missed your last but one post. Where would error_log() be added?

Cheers, Frank

Sorry @frank-j, now I’ve forgotten to respond after reading your post ??

Here’s an updated snippet:

add_action( 'wp_head', function() { error_log("starting wp-Typography buffering"); ob_start( function( $buffer ) { return WP_Typography::process( $buffer ); } ); } );
add_action( 'wp_footer', function() { ob_end_flush(); error_log("ending wp-Typography buffering" ); } );

You should see something like this in your PHP log then:

...
starting wp-Typography buffering
...
ending wp-Typography buffering
...

If those lines are not there, Divi is not actually running those hooks.

Hi @frank-j, have you been able to solve the issue?

Hi Pepe,

thanks for getting back to this.

I haven’t worked on any Divi projects since five months now. Time to get back to it and work on my projects that had no high priority due to other stuff. Divi is really great …

Checking the website that I mentioned above I could not find any relevant problems though: All elements on the right side show hyphenation.

So it looks like Elegant Themes has fixed the problem in the meanwhile.

I will double check after I started to work on my Divi projects and will notify you in case the problem will occur again.

Thanks again for being so careful to remind me of this!

Cheers, Frank