WP 3.5 Compatible version (download here)

Will, sorry, I haven’t got the code in a repository at the moment. The patch is against the latest version of Scott’s code (i.e. the one you can download here).

Am I correct assuming that the Media Credit code that still exists in a year’s worth of posts (but which is being ignored, thanks to the hack offered in this forum last year) will work with the new patch/version?

piantadosi, what exactly are you talking about?

sorry if i wasn’t clear or misunderstood something, pepe. i was referring to the fix that was posted here and on scott’s site 8 months ago — code that went in the theme’s functions.php file and basically allowed the media credit shortcode to be ignored (saving us from having to go into the db and remove it, for about 500 posts on our site).

since the media credit code is still in all those individual posts, i was just confirming that the patch will work without having to modify any of that. but again i haven’t tested the patch; we’re in the middle of rebuilding our dev site at the moment.

@piantadosi: that should work fine. The code that was posted to put in your functions.php just intercepts the shortcodes and prevents them from displaying. If you remove that from your functions.php file and install the patched media-credit plugin (and your site has the same user IDs as before), it should work (assuming the patch works on your site).

Peter, let’s expedite the process — how about I add you as a contributor on Media Credit? You can commit the latest code to trunk and I’ll try it out (and then others can do the same) and then we’ll tag it after a bit of testing. How does that sound? I want to expedite this but haven’t given it the priority it deserves.

Thanks,
Scott

Yes, I think that’s a good idea!

Greetings,
Peter

Added! Please keep the changelog additions, but remove the Stable Tag change. Also, can we test up to 3.6? And can we check if the changes work with older versions of WordPress? I’d like to maintain backward compatibility if it’s not difficult. Finally, is any upgrade script required or were there no database changes?

It works on 3.6 (because that’s what I’m running). There were no database changes.

However, compatibility with anything pre 3.5 is still a problem – the media dialog changes are pretty big plus my patch deliberately removed some outdated JS code. Older versions of WP come with older jQuery versions, so we’d have to basically integrate two completely different autocomplete codebases and switch between them from PHP.

I’d say we commit the current code to give people a chance to try it out, but roll it back and make a compatible version as described above before doing a release. The other solution would be to drop compatibility with anything pre 3.5. I have to admit, I don’t quite see the point in keeping the plugin compatible with a version that old. People should update for security reasons if nothing else (and the process is pretty painless, compared with some other CMS I have known). But as the main author, it’s of course your choice.

Thanks for your thoughts. I think you’ve convinced me — 3.5+ compat is just fine. Let’s get this into trunk, hopefully others on the thread can try it out, and then let’s tag. You can update the tested up to to include 3.6 ??

Tomorrow, I’m going to be importing a bunch of posts into WordPress from our old CMS. I’ll be using media credit. Since I don’t yet have media credit working, it’s hard for me to test that my import is working correctly. Could someone let me know if the syntax I have is correct?

I added line breaks to make it easier to read. I need it to work correctly with and without an included caption:

With Caption

[caption id="attachment_54842" align="alignnone" width="648"]
[media-credit name='John Doe' align='alignnone' width='648']
<img src="https://example.com/" width="648" height="206" />
Caption here: Vestibulum id ligula porta felis euismod semper.
[/media-credit]
[/caption]

Without Caption:

[caption id='attachment_54765' align='alignnone' width='648']
[media-credit name='John Doe' align='alignnone' width='648']
<img src='https://example.com/kitty.png' width='648' height='405' />
[/media-credit]
[/caption]

My main questions are:

– is the caption tag still included when there is no caption?
– Do I start/end the media-credit tag in the correct place?

I spot checked on a site running an old version of WP where Media Credit was working fine.
With a caption, the caption should go inside the caption shortcode, no? Something like:
[caption caption="Caption here..."][media-credit]<img />[/media-credit][/caption]
Without a caption, the [caption][/caption] should not be necessary.

A question about Media Credit’s compatibility with 3.6:

We have a site on WP 3.6; with an installation of the Media Credit plugin (Version 1.1.101).

Recently we have found that when you insert text (e.g. “Photo by Scott Bressler”) into the “Credit” field, when uploading an image to a post (as we have always done); no credit is displayed under the image on the post.
Furthermore, when you return to the uploaded image in the media library, the text that was typed in the “credit” field (e.g. “Photo by Scott Bressler”) is no longer there.

However, when you type a [media-credit] shortcode next to your image tag in the editor; for example:

[media-credit name=”Photo by Scott Bressler” align=”alignright” width=”640″];

the credit is displayed under the image on the post just fine (even though the “credit” field for the image in the media library is blank).

Is this a compatibility issue with WP 3.6? Or are we doing something wrong?

We’ll wait till the the WordPress 3.5+ compatible version mentioned above has been added then update the Media Credit Version 1.1.101 still active on our site.

Hi Elethu,
Yeah, we’re fixing up Media Credit for recent versions of WordPress.
Thanks for your patience!
-Scott

Peter — any updates on committing a version of your patch to trunk?