@willemb2 – We did similar for several of those bug releases, posted the code solution, waited for one of the reporters to say they tried it and it worked before I pushed the final release button. This happened in minutes btw.
I’ll note the Ninja Forms link you posted was for a one user issue, we had dozens of users chime in within an hour or 2, not quite the same scale/scope.
The other errors there was no need to wait for confirmation, an error like Warning: Attempt to read property “term_id” on int
is pretty clear, add a proper type check to ensure only objects with that property are accessed that way and I don’t have to guess if its solved.
I’ll also point out that the above error can’t really be tested for without ever seeing someone break it that way. $wp_term_query->terms
is always an array of term_object
as is documented in WP core documentation.
Only if another plugin/custom code changed it to an array of integers
, which they shouldn’t, would this error be possible.
I appreciate your feedback, and typically agree, but our track record doesn’t represent that at all. We go 4+ weeks without updates regularly, but when there are issues in a new release, they must be addressed rapidly.
So I must respectfully disagree with your premise that multiple or fast updates are always a problem. In fact they are a necessity when applied correctly.
As a typical suggestion and hopeful way to make this a constructive conversation, these would be my suggestions for a live/production site.
- I never auto update anything, terrible idea from the start, shouldn’t have been added to core in such a dynamic ecosystem. Hard enough getting site admins to read changelogs as it is, with that on would it even matter if we listed breaking changes?
Now if auto updater had an option for security releases only, that might be better, but even then admin discretion should be taken into account.
I do however recommend auto updates for lots of things such as network firmwares and such, but that is much different than WP plugins.
- Outside of security updates, there is no rush to update every time one is available. If a new minor or major release comes out, no shame in waiting for a few patches or a couple days to pass before updating to it. This is typically best practice for IT professionals who wait until they know its been tested in the wild before deploying.
I’ll leave you with a simple question…
Would you propose we leave those Fatal WSOD (white screen) errors in the plugin for a few days? Keep in mind at scales of 40k+, minutes means potentially dozens or hundreds of additionally affected sites.