WordPress 4.4 Problems With Plugin

Hi Mihai,

I work with Andrew on his site and fixed this last night (UTC). It should be stressed that we are still running ver 3.9.4 of wp-e-c although I am in the process of upgrading to 3.11.

The problem was fixed by adding in cart-item.class.php, line 511 :
if ($this->custom_message == null) $this->custom_message = ”;

I found that custom_message was null and the subsequent insert was failing because of it.

I do have to wonder why the return value from $wpdb->insert() is not being checked and acted upon.

I’m having the same problem as Andrew. Any fix to this yet? I tried whitelamps suggestion and it took my entire site down. Definitely not the fix. Where’s this at Mihai?

The latest 3.11.1 should have the fix inside it:
https://github.com/wp-e-commerce/WP-e-Commerce/commit/3e1eb5570a6d6373394635218466eff2834bec4a

@sarjn15 can you check that file/line if the code is changed from null to ” ?

I’m looking into it.

@sarjn15 – if it “took the entire site down” then you didn’t enter it right. Note that the end bit of my fix is two single quotes, not a double quote. But Mihai’s fix is the one to use, if you don’t want to upgrade to 3.11.1.

We have ourselves since upgraded to 3.11.1 and as it turns out could probably have done that last night without any problems. But our priority then was simply to get back to being able to sell things. Upgrades we prefer to do in a more controlled fashion.

Why this manifested itself after a WordPress upgrade I don’t know – any clues Mihai?

Not sure if I’m looking at the right file.. My line 101 reads…

* @param meta key name

Also, I have upgraded my plugin to version 3.11.1

@sarjn15 the file is: wp-e-commerce/wpsc-components/theme-engine-v1/helpers/ajax.php

@whitelamp I noticed the issue a while back while still on the beta WP versions. The git pull is from Oct 28 so that’s about when i spotted the issue. Not sure if its WordPress or WP eCommerce related.

And you still have the problem?

Mihai,

Thanks for that! Checked the file. Line 101 has the two single quotes rather than the null. Any other thoughts?

@mihai, sorry, I was asking sarjn15 if they still had the problem.

@sarjn15: time to start debugging I am afraid. Can you examine the database? Personally I upload a copy of the adminer tool:
https://www.adminer.org/
to do this.

If you can confirm that there’s an entry for a new order in the purchase logs table, but no corresponding entry in the cart contents table, then you know that the the cart contents are not getting saved. So you want to see what is going on inside save_to_db() inside cart-item.class.php. Depending on your hosting you may be able to use error_log(); or – it’s ugly but it works – use lines like
mail(‘[email protected]’, ‘debug’, print_r($foo, true));

Hi , I too experienced the same difficulty as detailed above

checking the error logs :
database error [13-Dec-2015 01:14:53 UTC] WordPress database error Column ‘pnp’ cannot be null for query INSERT INTO wp_wpsc_cart_contents (prodid, name, purchaseid, price, pnp, tax_charged, gst, quantity, donation, no_shipping, custom_message, files, meta) VALUES (130, ‘DVD 10’, 768, 19.950000, NULL, 0.000000, 0.000000, ‘1’, 0, 0, ”, ‘N;’, NULL) made by require(‘wp-blog-header.php’), require_once(‘wp-load.php’), require_once(‘wp-config.php’), require_once(‘wp-settings.php’), do_action(‘init’), call_user_func_array, wpsc_submit_checkout, wpsc_cart->save_to_db, wpsc_cart_item->save_to_db

the ‘pnp’ entry is null and causing th insert to fail.

I added a simple
if($shipping == null) $shipping =”;

to line 511 in the cart-item.class.php just before the function call .
I suspect there may be a more correct/elegant solution ?

Damian

That supressed the database error but did not solve the problem because now paypal says:

Unable to process payment. Please contact the merchant as the shipping address provided by the merchant is invalid, and the merchant has requested that your order must be shipped to that address.

Yup, I get the problem too.

Items are remembered in the cart as I go form page to page, but checkout at Paypal says nothing in cart. And I have 3.11.1

And neither of the above lines added to cart-item.class.php make any difference.