• Resolved 2candela2

    (@2candela2)


    Hello and thanks for the plugin

    When I add a font, the theme.json get updated with the new font, but it lacks the name key and WooCommerce gives this warning:

    PHP Warning: Undefined array key “name” in /home/hh/domains/fifthpress.org/public_html/style/wp-content/plugins/woocommerce/src/Internal/ComingSoon/ComingSoonRequestHandler.php on line 188

    In the theme.json I added the name key and the warning stopped

    Before:

    					"fontFamily": "Font Awesome 5 Free",
    					"slug": "font-awesome-5-free",
    					"fontFace": [
    						{
    							"fontFamily": "Font Awesome 5 Free",
    							"fontStretch": "",
    							"fontStyle": "normal",
    							"fontWeight": "400",
    							"src": [
    								"https://test.devel/wp-content/uploads/2024/07/fa-regular-400.woff2"
    							]
    						},
    						{
    							"fontFamily": "Font Awesome 5 Free",
    							"fontStretch": "",
    							"fontStyle": "normal",
    							"fontWeight": "900",
    							"src": [
    								"https://test.devel/wp-content/uploads/2024/07/fa-solid-900.woff2"
    							]
    						}
    					],
    					"isBcf": true
    				}
    

    After:

    					"fontFamily": "Font Awesome 5 Free",
    					"slug": "font-awesome-5-free",
    					"name": "font awesome",
    					"fontFace": [
    						{
    							"fontFamily": "Font Awesome 5 Free",
    							"fontStretch": "",
    							"fontStyle": "normal",
    							"fontWeight": "400",
    							"src": [
    								"https://test.devel/wp-content/uploads/2024/07/fa-regular-400.woff2"
    							]
    						},
    						{
    							"fontFamily": "Font Awesome 5 Free",
    							"fontStretch": "",
    							"fontStyle": "normal",
    							"fontWeight": "900",
    							"src": [
    								"https://test.devel/wp-content/uploads/2024/07/fa-solid-900.woff2"
    							]
    						}
    					],
    					"isBcf": true
    				}
    
Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter 2candela2

    (@2candela2)

    Also it would be nice if you use relative paths on the src key, so, you don’t have to change urls when you upload to the production server. I saw many people having the problem with http and changing to https….

    Thanks again!

    Plugin Support Herman Asrori (BSF)

    (@bsfherman)

    Hi @2candela2,

    Could you please let us know what you are trying to do and the steps to replicate it?

    As regards to the relative path, are you it’s not due to the migration process?

    I look forward to hearing from you.

    Kind regards,
    Herman ??

    Plugin Support Herman Asrori (BSF)

    (@bsfherman)

    Hi @2candela2,

    It’s been a while since I posted my response, and we haven’t heard from you since then.

    Anyway, it seems you are familiar with code. If you really think this is an issue and you have the fix, please rais a PR on our GitHub.

    I am marking this thread as Resolved due to inactivity. Feel free to start a new thread if there’s anything else related to this plugin, we can help you with.

    Kind regards,
    Herman ??

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.