Woocommerce 3.5.3 breaks Cart Cross-Rule Limits

I noticed that if you are using Woocommerce 3.5.3 and also Cart Cross-Rule Limits rule 5, the plugin breaks your site.
To recreate:

• Make a BOGO deal that is added when x products are in the cart
• Ensure Coupon mode is on in settings
• Ensure Cart Cross-Rule Limit is set onto option 5 (No woo coupon if deal is applied)
• Ensure you are using Woocommerce 3.5.3
• Add products
• When you reach x products the site will crash on the frontend with error 500.

The 500 error is related to timeout errors in POST requests on the basket page, this then produces other timeout warnings.
In the browser console while this error happens you will see multiple ajax warnings, including this:
{type: "warning", message: "sizeof(): Parameter must be an array or an object that implements Countable", file: "wp-content/plugins/pricing-deals-for-woocommerce/core/vtprd-apply-rules.php", line: 403, stack: Array(15),?…}

The error resolves if you set Cart Cross-rules to default, turn the price deal off or disable the plugin. This error also doesn’t occur on Woocommece 3.5.2 (One of my staging sites which I tested this on was on an older Woocommerce version, thats how I know this to be the case).

In addition I used WordPress Query Monitor to find an error warning coming from this plugin:
sizeof(): Parameter must be an array or an object that implements Countable

I do not know if any other settings are affected by this bug.

• This topic was modified 5 years, 10 months ago by tandsmichael.