Wonderful plugin but a little bug
-
I’ve use this plugin for years, but there is a bug I found:
In
collapsFunctions.js
, on the line 39 and line 51, Robert use thejQuery.live
forclick
event, but thelive
function is removed on jQuery 1.9 [1], should useon
function instead. If you do not includejquery-migrate
, this plugin won’t work on collapse/expand[1] https://jquery.com/upgrade-guide/1.9/#live-removed
I’ve modified the
collapsFunctions.js
on my local, and hope this change will merge into n next versionbefore
`
./collapsFunctions.js:39: jQuery(‘#’ + id + ‘ span.expand’).live(‘click’, function() {
./collapsFunctions.js:51: jQuery(‘#’ + id + ‘ span.collapse’).live(‘click’, function() {
`
after
`
./collapsFunctions.js:39: jQuery( document ).on(‘click’, ‘#’ + id + ‘ span.expand’, function() {
./collapsFunctions.js:51: jQuery( document ).on(‘click’, ‘#’ + id + ‘ span.collapse’, function() {
`
- The topic ‘Wonderful plugin but a little bug’ is closed to new replies.