Will Break Threaded Comments (resurfacing)

Jose,

It is possible that there are 2 different issues going on. I just tested the latest release against Genesis and 2013 and the threaded comments links seemed to be working as expected. The previous issue you referenced had problems breaking the #respond hash. This should be the case.

What theme are you using for you site? Can you point me to your site where the threaded comments are?

Thanks

Hello Mike,

Thanks for the reply.

When the plugin was activated, threaded comments were not working. Also, when people clicked on “Reply”, the link would cause the window to scroll down a bit, but nothing else would happen.

When I deactivated the plugin, threaded comments begin to work again. The CSS for threaded comments simply pushes the reply about 75px to the right.

Also, when I deactivated the plugin, the reply link begin to work again. This means that when someone clicks reply, no matter where in the conversation, a reply box will appear right under the commment that will be replied to.

Here is the link to the website and to the story that went viral that unfortunately did not have threaded comments working at the time.

https://www.echoparkforums.com/2014/05/dog-owners-beware-avoid-rocket-dog-walking-echo-park-los-angeles/

the theme is a free wordpress theme called Vantage. I am using a child theme of it. The CSS that was customized in comments did not affect the CSS for threaded comments for the theme.

Either way, as you can see in the live website, with the child theme activated, threaded comments are working with the plugin deactivated.

Let me know if you need any assistance or have questions.

Thank you

Jose

PS…the threaded comments that you DO see in the post were done after the deactivation of the plugin. By me and others, to test.

Jose

Jose,

The 5.4 version I just uploaded should correct the issue. The problem was handling of attached javascript events on the link where it was encoded to with nested quotes/double quotes.

Your thread comment reply links looked like

<a class="comment-reply-link" href="#comment-758" onclick="return addComment.moveForm("comment-758", "758", "respond", "3907")">Reply</a>

The plugins parser started parsing the onclick=”…. attribute but chocked when it saw this next ” after the ( instead of bypassing all the ” until the one after the closing).

These javascript events are simply just a pain because there are many different ways to attach a function including defining one inline.

Hopefully this resolves the issue you saw. sorry for it impacting your comment on the one post.

Mike

Hey Mike,

Thanks for looking into this and for explaining the problem. I see that the upgrade is available. I will try to upgrade it, check how it’s working, and report back.

Thank you,
Jose

Hello Mike,

I updated plugin, activated again, and tried the links. Unfortunately, threaded comments and the reply link were not working again.

Before deactivating, I went to the External Links plugin settings to see what I could find.

I unchecked “Apply these settings to all outbound links on the site except those in scripts, styles and the html head section.” in hopes that it would not apply the plugin settings to the comment links, and it worked.

Currently, with the updated plugin, activated, the reply to link and threaded comments are working.

However, I am wary to want to leave the plugin activated in fear that it might have a negative effect on other script/style links on the site without me knowing.

What do you suggest?

Thank you,
Jose

So you’re saying it works if you don’t use the Apply Global (top) option?

So it sounds like the links in the post/page content and comments are working now with my change.

When you use the global link it uses a different technique so it can impact the entire page. For just the content area it uses a wordpress hook/filter to alter the content.

So you’re saying it works if you don’t use the Apply Global (top) option?

Yes

Will not clicking the global option ensure that the plugin has an effect only on the content area?

Thank you,
Jose

Yes It will only affect links in the content, excerpts, comments (and optionally any text widget) if Apply Global is off.

Now the question is what other link is found globally that would cause the comments to to break.

So globally off still affects the comments, yet the issue in this thread is not happening with global off, correct?

Well, for now I will leave global off and plugin activated. It seems everything is working right.

Please let me know if you come across any more information.

thank you for your assistance.

Yes with Globally Off comments are still affected. By default it processes links and images found in the content, excerpt and comments. You can them optionally add links found in text widgets.

Globally processes all links found in the body of the site for headers, main/content, sidebars and footer. Those links in the html <head> section, javascript, styles are ignored.

Thanks! Sorry for delayed response.