Widget displays “0” when description is blank

  • Resolved Tyler Tork

    (@tylertork)


    5 years, 6 months ago

    The variable $desc is assigned thus:
    $desc = ! empty( $data['desc'] ) ? $data['desc'] : 0;
    However, when the variable is used, there’s no test to skip outputting anything if the value is 0. Instead it prints “0” because the test is for whether the value is empty string. Please change the above assignment or the test to represent the “no description” situation consistently.

Viewing 12 replies - 1 through 12 (of 12 total)

  • Have to agree, this is now very annoying and would be great if you could change it back to how it was

    Hi, I too have just noticed this “0” appearing in my widget. I’d initially thought it was a typo of mine, but checking on here I see others have the same issue.

    I’m sure this wasn’t an issue before – can it be changed back somehow?

    I have the same problem.

    Plugin Contributor Malay Ladu

    (@malayladu)

    @tylertork Thanks for pointing this out.

    @kevinagar @hypno_pboro @kevinagar @tylertork This will be fixed in the upcoming version of Email Subscribers.

    Thx for that, I thought it might have been something I’d added in the html by mistake.

    Appreciate your quick reply.

    Ward Graham

    (@eagrayhamgmailcom)

    fix
    in line 125 $desc is set to 0 if nothing

    in line 177 the check of nothing…
    <?php if ( $desc != “” ) { ?>

    I changed line 125 to set as nothing if nothing rather than 0
    $desc = ! empty( $data[‘desc’] ) ? $data[‘desc’] : “”;

    Plugin Contributor Malay Ladu

    (@malayladu)

    @eagrayhamgmailcom Thanks for the code.

    Just want to update you that we have fixed this issue with ES 4.0.18.

    Kindly, upgrade your Email Subscribers and check once again and confirm the same.

    Hi Malay Ladu,

    Email Subscribers plugin updated and the “O” has disappeared so all’s good again.

    Thank you.

    Plugin Contributor Malay Ladu

    (@malayladu)

    @hypno_pboro Thanks for the confirmation.

    Hi Malay

    I like your plugin.
    I updated and red the new rules (the entire text with explanations and your apologize). That is ok. I fixed some little things manually.

    Now i wonder. I have a child theme under WP 4.9.10 and your plugin version 4.0.17
    it show a “0” online (probably because I had put nothing for “description”.) Never mind, since, I found a sentence to add.

    Now do you think that I could update you Plugin to 4.0.18 with any bad consequences?

    Today WP is asking to update to 5.2 but I still have some plugins that I wonder that they are not ready to support… What do you think of all this?

    And last but not least: how can I change the button “Subscribe” in another word?

    Thank you very much!
    Best regards.
    Anne

    Anne

    • This reply was modified 5 years, 6 months ago by Scribelle.
    • This reply was modified 5 years, 6 months ago by Scribelle.
    • This reply was modified 5 years, 6 months ago by Scribelle.
    Plugin Contributor Malay Ladu

    (@malayladu)

    Hi Anne,

    Thanks for reaching out to us.

    “0” issue is already fixed in ES 4.0.18. Please upgrade ES to 4.0.18. If ES 4.0.17 is working without issue with your child theme, 4.0.18 should work without issue.

    We haven’t tested ES with WordPress 5.2.

    Ok.
    Fine.
    Thank you Malay for your rapid answer. ??

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘Widget displays “0” when description is blank’ is closed to new replies.