“Who can see this Link” appears twice on menu item

here is how it looks

https://klapaustralia.org/wp/wp-content/uploads/2020/04/2020-04-16-01_52_20-User-Menu-Double.png

@erlee – Technically yes, but it is likely a bug in your mega menu plugin I’m assuming. WordPress made changes in 5.4 that required plugins like ours that add fields to the nav menu to make changes to prevent duplicating fields. Seems that plugin hasn’t yet (or did it in a way that resolved duplicate fields for them but not others using that same hook) and causing other plugins to also render twice.

Basically we render fields on a hook that didn’t exist before in core. We like they do added it in a way that was compatible with any other plugin using the same method. But now WP core ads that hook and so does your other plugin causing our fields to show twice.

Hope that helps.

• This reply was modified 4 years, 7 months ago by Daniel Iser.

Hi Both,

I can see it is a bug, but it won’t be MMM causing that, we do not use the action mentioned or add fields to the menu item options in that way (we simply use JavaScript to add a button to each menu item). It may be another plugin, or theme, that has not been updated to use the new 5.4 action.

Regards,
Tom

@megamenu – Much appreciate you weighing in. Hopefully we can get to the bottom of it. The change in core was much needed, but seems many themes and some plugins didn’t update as needed.

Just chiming in – I’m working with a fresh install of wordpress + woocommerce and this is also occuring. Simply activating the plugin (I have no other plugins outside of woocommerce enabled) makes the “who can see this” dropdown in each menu item appear twice.

@ashikai – Can you confirm everything is on the latest version? If so can you also confirm your using one of the default themes? If not I’d say your theme is likely the cause as I just fired up a fresh install of WP 5.4 + WooCommerce 4.0.1 + User Menus 1.2.3 and its working correctly for me:

Keep me posted. But from everything I’m reading in the support forums for other plugins that also add nav menu fields, there are a lot of themes and less popular plugins that did not update for WordPress 5.4 core updates and that is likely what is happening in each of your cases unfortunately.

Maybe i’m wrong, but so far all cases that I have personally dealt with which have been resolved or at least debugged fully were from an out of date theme (hasn’t been a plugin so far for any of our users though).

@danieliser Yes, everything is the latest version, however I am using Underscores rather than Twentytwenty, but I don’t think that makes a difference? Jetpack is also active, so I’ll try deactivating and seeing if either of those things may be impacting it.

Have the same issue, no MM installed,
i’m using wp 5.4.1 and astra theme 2.4.3

@@badi2018 – Can you test using the health check plugin’s troubleshooting mode. Preferably troubleshoot User Menus & retest, then activate all your normal plugins 1 by 1 and retest. If it works up til then, activate your Astra theme. If it breaks then you will know for sure what plugin or theme causes the issue this way.

Honestly you could all have the same issue from different sources. Not sure there is anything we can do from our end til we narrow it to a specific culprit and debug that directly. Even then there are scenarios we can’t patch for. Hopefully this is not that.

@danieliser thanks a lot, it’s ok for me i just updated ACF

@badi2018 – So updating only ACF fixed it? Will check their changelogs, but did you happen to notice which version you were upgrading from?

yes only ACF update fixed it,
from 5.8.7 to 5.8.9

Hi,

I SOLVED this issue.

It happens some time when you remove existing plugin from FTP client like e.g. filezilla, winscp and upload again plugin folder by FTP client or install it from admin panel.

In such case go to the admin panel > menu and remove the menu items and add them again freshly.

It works for me.!!