whitelist taken into account although disabled

  • Resolved dariodeaktualisierungorg

    (@dariodeaktualisierungorg)


    8 years, 6 months ago

    in one of the last releases, the isValid() function in lib/models/Validate.php got rewritten to say

    $isValid = $checkWhitelist;

    in line 30, changing the default behaviour from “if whitelist is disabled, anything not blacklisted is ok” to “if whitelist is disabled, everything is rejected, except if it’s blacklisted, then it’s rejected as well”

    i propose to fix this by moving the intended $isValid=true inside the if ( 1 == $checkWhitelist ) {.. block

Viewing 1 replies (of 1 total)
  • Plugin Author CreativeMindsSolutions

    (@creativemindssolutions)

    Hi,

    Moving the $isValid=true inside this if doesn’t make sense as it’s value is set there anyway, but I understand the logical problem, and necessity to setup the base value of this variable before checking the FreeDomains list.

    So now, if whitelist is disabled – all of the e-mails will be treated as valid.

    Best,
    CM Plugins

Viewing 1 replies (of 1 total)
  • The topic ‘whitelist taken into account although disabled’ is closed to new replies.